Page MenuHomeSoftware Heritage
Differential D3401

loader-svn: tests: Refactor start-from-scratch use case
ClosedPublic
Actions

Authored by ardumont on Jul 3 2020, 9:13 AM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T2462: svn loader: Refactor tests using pytest fixtures
Commits
rDLDSVNfca9e8b2af6e: tests: Refactor start-from-scratch use case
Summary

Related to T2462

Test Plan

tox

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 3 2020, 9:13 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 3 2020, 9:13 AM
swh-public-ci added a comment.Jul 3 2020, 9:15 AM

Build is green

Patch application report for D3401 (id=12054)

Could not rebase; Attempt merge onto ee23fd7582...

Updating ee23fd7..4098bf5
Fast-forward
 requirements-test.txt               |   1 +
 swh/loader/svn/tests/conftest.py    |  15 +-
 swh/loader/svn/tests/test_loader.py | 302 +++++++++++++++++-------------------
 3 files changed, 153 insertions(+), 165 deletions(-)
Changes applied before test
commit 4098bf5105853e23053412e2937e0ad20a169e0a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 09:13:43 2020 +0200

    tests: Refactor start-from-scratch use case
    
    Related to T2462

commit 388f2e854cb598169c70772b1d39aeb3cb172dce
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 08:12:06 2020 +0200

    tests: Refactor scenario about visits on repository with changes
    
    For this, switch to using a pg storage to share the state amongst visit.
    
    Related to T2462

commit a846f61d164da4ee826ae2fcc48f965b307e6f67
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 07:29:35 2020 +0200

    tests: Refactor scenario about visits on repository with no change
    
    Related to T2462

commit 5d770ec3934b84413b13b63a19443592832c8e0a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 2 19:19:13 2020 +0200

    Start tests with pytest refactoring: Add scenario for 1 visit
    
    This starts to align the existing svn tests with the core/package ones. For
    now, utilities functions are in this repository close to the tests. They will
    most possibly be refactored out in swh-loader-core at some point.
    
    Related to T2462

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/37/ for more details.

Harbormaster completed remote builds in B13275: Diff 12054.Jul 3 2020, 9:15 AM
ardumont updated this revision to Diff 12055.Jul 3 2020, 9:16 AM

Add some more assertions on status

swh-public-ci added a comment.Jul 3 2020, 9:18 AM

Build is green

Patch application report for D3401 (id=12055)

Could not rebase; Attempt merge onto ee23fd7582...

Updating ee23fd7..23c854a
Fast-forward
 requirements-test.txt               |   1 +
 swh/loader/svn/tests/conftest.py    |  15 +-
 swh/loader/svn/tests/test_loader.py | 304 +++++++++++++++++-------------------
 3 files changed, 155 insertions(+), 165 deletions(-)
Changes applied before test
commit 23c854aa547d59867f5c34e788a44b1b3114821f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 09:13:43 2020 +0200

    tests: Refactor start-from-scratch use case
    
    Related to T2462

commit 388f2e854cb598169c70772b1d39aeb3cb172dce
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 08:12:06 2020 +0200

    tests: Refactor scenario about visits on repository with changes
    
    For this, switch to using a pg storage to share the state amongst visit.
    
    Related to T2462

commit a846f61d164da4ee826ae2fcc48f965b307e6f67
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 07:29:35 2020 +0200

    tests: Refactor scenario about visits on repository with no change
    
    Related to T2462

commit 5d770ec3934b84413b13b63a19443592832c8e0a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 2 19:19:13 2020 +0200

    Start tests with pytest refactoring: Add scenario for 1 visit
    
    This starts to align the existing svn tests with the core/package ones. For
    now, utilities functions are in this repository close to the tests. They will
    most possibly be refactored out in swh-loader-core at some point.
    
    Related to T2462

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/38/ for more details.

Harbormaster completed remote builds in B13276: Diff 12055.Jul 3 2020, 9:18 AM
ardumont retitled this revision from tests: Refactor start-from-scratch use case to loader-svn: tests: Refactor start-from-scratch use case.Jul 3 2020, 9:40 AM
ardumont updated this revision to Diff 12057.Jul 3 2020, 9:40 AM

Rebase

swh-public-ci added a comment.Jul 3 2020, 9:43 AM

Build is green

Patch application report for D3401 (id=12057)

Could not rebase; Attempt merge onto ee23fd7582...

Updating ee23fd7..036d3fd
Fast-forward
 requirements-test.txt               |   1 +
 swh/loader/svn/tests/conftest.py    |  15 +-
 swh/loader/svn/tests/test_loader.py | 377 ++++++++++++++----------------------
 3 files changed, 154 insertions(+), 239 deletions(-)
Changes applied before test
commit 036d3fdcd16101fa7a983c1f46a6fbf571daf8b7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 09:13:43 2020 +0200

    tests: Refactor start-from-scratch use case
    
    Related to T2462

commit 464d36c1a10cbd4e145186a7ad795596c3aa278f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 08:12:06 2020 +0200

    tests: Refactor scenario about visits on repository with changes
    
    For this, switch to using a pg storage to share the state amongst visit.
    
    Related to T2462

commit a846f61d164da4ee826ae2fcc48f965b307e6f67
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 07:29:35 2020 +0200

    tests: Refactor scenario about visits on repository with no change
    
    Related to T2462

commit 5d770ec3934b84413b13b63a19443592832c8e0a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 2 19:19:13 2020 +0200

    Start tests with pytest refactoring: Add scenario for 1 visit
    
    This starts to align the existing svn tests with the core/package ones. For
    now, utilities functions are in this repository close to the tests. They will
    most possibly be refactored out in swh-loader-core at some point.
    
    Related to T2462

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/40/ for more details.

Harbormaster completed remote builds in B13278: Diff 12057.Jul 3 2020, 9:43 AM
vlorentz added a subscriber: vlorentz.Jul 3 2020, 10:09 AM

Here too, you're removing assertions and not adding equivalents

ardumont added a comment.EditedJul 3 2020, 10:17 AM

Here too, you're removing assertions and not adding equivalents

I initially checked the internal revisions, directories (even contents in some)
and all that because it was an early loader (I did not trust entirely what it
did at the time).

Now i'm trusting the merkle property. Thus, only checking the top-level
snapshot only as we do in other loaders which sounds enough to me.

I can add the get_stats part in there to check the origin-visit is 1 visit more
from the previous visit. And check the snapshot number is still 1 but that's
not much. Would that be what you miss?

Also the coverage did not move (iirc).

vlorentz accepted this revision.Jul 3 2020, 10:33 AM
In D3401#83584, @ardumont wrote:

Also the coverage did not move (iirc).

well yeah, the assertions don't run any code, they just check values.

But ok then

This revision is now accepted and ready to land.Jul 3 2020, 10:33 AM
ardumont updated this revision to Diff 12069.Jul 3 2020, 10:55 AM

Add more stats assertions

ardumont updated this revision to Diff 12070.Jul 3 2020, 10:55 AM

Use correct commit (damn!)

swh-public-ci added a comment.Jul 3 2020, 10:56 AM

Build is green

Patch application report for D3401 (id=12069)

Rebasing onto 7225c537e3...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-49-D3401.
Changes applied before test



See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/49/ for more details.
Harbormaster completed remote builds in B13290: Diff 12069.Jul 3 2020, 10:56 AM
swh-public-ci added a comment.Jul 3 2020, 10:58 AM
Build is green



Patch application report for D3401 (id=12070)



Rebasing onto 7225c537e3...



Current branch diff-target is up to date.





Changes applied before test



commit fca9e8b2af6ebf7409c61426f634b8f266c0fe2b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 09:13:43 2020 +0200

    tests: Refactor start-from-scratch use case
    
    Related to T2462



See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/50/ for more details.
Harbormaster completed remote builds in B13291: Diff 12070.Jul 3 2020, 10:58 AM
Closed by commit rDLDSVNfca9e8b2af6e: tests: Refactor start-from-scratch use case (authored by ardumont).  ·  Explain WhyJul 3 2020, 10:58 AM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLDSVNfca9e8b2af6e: tests: Refactor start-from-scratch use case.
Revision Contents
Changeset List
PathSize
swh/
loader/
svn/
tests/
74 lines
Diff 12071
View Options
swh/loader/svn/tests/test_loader.py
Loading...
About · Developer information · Legal