loader-svn: tests: Refactor svn-eol-style scenario
ClosedPublic
Actions

Authored by ardumont on Jul 3 2020, 10:39 AM.

Details

Reviewers

vlorentz
douardda

Group Reviewers

Reviewers

Maniphest Tasks

T2462: svn loader: Refactor tests using pytest fixtures

Commits

rDLDSVN62973d84471a: tests: Refactor svn-eol-style scenario

Summary

@vlorentz I think i did right about the assertions this time on the first go ;)

Related to T2462

Test Plan

tox

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 3 2020, 10:39 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 3 2020, 10:39 AM

Build is green

Patch application report for D3403 (id=12061)

Could not rebase; Attempt merge onto ee23fd7582...

Updating ee23fd7..8123ed7
Fast-forward
 requirements-test.txt               |   1 +
 swh/loader/svn/tests/conftest.py    |  18 +-
 swh/loader/svn/tests/test_loader.py | 665 ++++++++++++++----------------------
 3 files changed, 275 insertions(+), 409 deletions(-)

Changes applied before test

commit 8123ed7d0efc9d28d0b1b64184d908b27169fa00
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 10:33:03 2020 +0200

    tests: Refactor svn-eol-style scenario
    
    Related to T2462

commit d9de08928d9a1a1d2d87e5c9922159d221ac5119
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 09:37:30 2020 +0200

    tests: Refactor scenario about starting from existing revision
    
    This adds both check for the scenario about repository with or without changes.
    
    Related to T2462

commit b917cdf8eeb532ef82a5abfe94465973f6705ea3
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 09:13:43 2020 +0200

    tests: Refactor start-from-scratch use case
    
    Related to T2462

commit 91e3c1289485ac93680db50f2cb8604c7fec43ca
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 08:12:06 2020 +0200

    tests: Refactor scenario about visits on repository with changes
    
    For this, switch to using a pg storage to share the state amongst visit.
    
    Related to T2462

commit 0094bac7d73705173849cf44f33120de68707fdf
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 07:29:35 2020 +0200

    tests: Refactor scenario about visits on repository with no change
    
    Related to T2462

commit 5c46affea65d6fb9a922d4f6ff0ab8920e121db8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 2 19:19:13 2020 +0200

    Start tests with pytest refactoring: Add scenario for 1 visit
    
    This starts to align the existing svn tests with the core/package ones. For
    now, utilities functions are in this repository close to the tests. They will
    most possibly be refactored out in swh-loader-core at some point.
    
    Related to T2462

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/44/ for more details.

Harbormaster completed remote builds in B13282: Diff 12061.Jul 3 2020, 10:40 AM

Rename variable

Build is green

Patch application report for D3403 (id=12063)

Could not rebase; Attempt merge onto 5c46affea6...

Updating 5c46aff..2be28db
Fast-forward
 requirements-test.txt               |   1 +
 swh/loader/svn/tests/conftest.py    |   6 +-
 swh/loader/svn/tests/test_loader.py | 579 +++++++++++++-----------------------
 3 files changed, 214 insertions(+), 372 deletions(-)

Changes applied before test

commit 2be28db2396e25e5da248299ba3df15b274ed377
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 10:33:03 2020 +0200

    tests: Refactor svn-eol-style scenario
    
    Related to T2462

commit d9de08928d9a1a1d2d87e5c9922159d221ac5119
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 09:37:30 2020 +0200

    tests: Refactor scenario about starting from existing revision
    
    This adds both check for the scenario about repository with or without changes.
    
    Related to T2462

commit b917cdf8eeb532ef82a5abfe94465973f6705ea3
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 09:13:43 2020 +0200

    tests: Refactor start-from-scratch use case
    
    Related to T2462

commit 91e3c1289485ac93680db50f2cb8604c7fec43ca
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 08:12:06 2020 +0200

    tests: Refactor scenario about visits on repository with changes
    
    For this, switch to using a pg storage to share the state amongst visit.
    
    Related to T2462

commit 0094bac7d73705173849cf44f33120de68707fdf
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 07:29:35 2020 +0200

    tests: Refactor scenario about visits on repository with no change
    
    Related to T2462

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/45/ for more details.

Harbormaster completed remote builds in B13284: Diff 12063.Jul 3 2020, 10:43 AM

vlorentz accepted this revision.Jul 3 2020, 10:51 AM

This revision is now accepted and ready to land.Jul 3 2020, 10:51 AM

LGTM but I'd prefer the commit message be self-contained, i.e. explicitly explain the unttest->pytest conversion rather then delegating this to a task in the forge.

Rebase

Build is green

Patch application report for D3403 (id=12073)

Could not rebase; Attempt merge onto fca9e8b2af...

Updating fca9e8b..62973d8
Fast-forward
 swh/loader/svn/tests/test_loader.py | 287 +++++++++++++++---------------------
 1 file changed, 116 insertions(+), 171 deletions(-)

Changes applied before test

commit 62973d84471a0b25b182d034d2091d6c7d0936e8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 10:33:03 2020 +0200

    tests: Refactor svn-eol-style scenario
    
    Related to T2462

commit 58ae736a11d6d259c6b26885a1c7cf4f43f711b8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 09:37:30 2020 +0200

    tests: Refactor scenario about starting from existing revision
    
    This adds both check for the scenario about repository with or without changes.
    
    Related to T2462

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/52/ for more details.

Harbormaster completed remote builds in B13294: Diff 12073.Jul 3 2020, 11:02 AM

Closed by commit rDLDSVN62973d84471a: tests: Refactor svn-eol-style scenario (authored by ardumont). · Explain WhyJul 3 2020, 11:03 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDSVN62973d84471a: tests: Refactor svn-eol-style scenario.