Page MenuHomeSoftware Heritage

tests: Drop dead code
ClosedPublic

Authored by ardumont on Jul 3 2020, 1:59 PM.

Details

Summary

Those utility classes are no longer needed

Related to T2462

Test Plan

tox

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 3 2020, 1:59 PM

Build is green

Patch application report for D3411 (id=12094)

Could not rebase; Attempt merge onto 4cb4b0301e...

Updating 4cb4b03..978a50d
Fast-forward
 .../resources/pkg-gourmet-tampered-rev6-log.tgz    | Bin 0 -> 133120 bytes
 swh/loader/svn/tests/test_loader.py                | 203 +++++----------------
 2 files changed, 44 insertions(+), 159 deletions(-)
 create mode 100644 swh/loader/svn/tests/resources/pkg-gourmet-tampered-rev6-log.tgz
Changes applied before test
commit 978a50d2edce7b395d914b8cbb2b1e7442c806ca
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 13:59:25 2020 +0200

    tests: Drop dead code
    
    Related to T2462

commit 01f9382e7442ef6510d016b7f7f42d6ac4c04b22
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 13:52:16 2020 +0200

    tests: Refactor repository with tampered information scenario
    
    This actually uses a real modified repository.
    
    Prior to this, this faked the alteration by modifying the input of the loader
    which is a hack.
    
    Related to T2462

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/61/ for more details.

ardumont updated this revision to Diff 12097.Jul 3 2020, 2:32 PM

Drop some more dead code

Build is green

Patch application report for D3411 (id=12097)

Could not rebase; Attempt merge onto 4cb4b0301e...

Updating 4cb4b03..1b6d26b
Fast-forward
 .../resources/pkg-gourmet-tampered-rev6-log.tgz    | Bin 0 -> 133120 bytes
 swh/loader/svn/tests/test_loader.py                | 222 ++++-----------------
 2 files changed, 44 insertions(+), 178 deletions(-)
 create mode 100644 swh/loader/svn/tests/resources/pkg-gourmet-tampered-rev6-log.tgz
Changes applied before test
commit 1b6d26bdd0444504672ff25f413940d408557728
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 13:59:25 2020 +0200

    tests: Drop dead code
    
    Related to T2462

commit 01f9382e7442ef6510d016b7f7f42d6ac4c04b22
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 13:52:16 2020 +0200

    tests: Refactor repository with tampered information scenario
    
    This actually uses a real modified repository.
    
    Prior to this, this faked the alteration by modifying the input of the loader
    which is a hack.
    
    Related to T2462

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/63/ for more details.

ardumont updated this revision to Diff 12098.EditedJul 3 2020, 2:33 PM

Drop last unused variable

anlambert accepted this revision.Jul 3 2020, 2:34 PM
anlambert added a subscriber: anlambert.

\o/

This revision is now accepted and ready to land.Jul 3 2020, 2:34 PM

Build is green

Patch application report for D3411 (id=12098)

Could not rebase; Attempt merge onto 4cb4b0301e...

Updating 4cb4b03..db24c5e
Fast-forward
 .../resources/pkg-gourmet-tampered-rev6-log.tgz    | Bin 0 -> 133120 bytes
 swh/loader/svn/tests/test_loader.py                | 226 ++++-----------------
 2 files changed, 44 insertions(+), 182 deletions(-)
 create mode 100644 swh/loader/svn/tests/resources/pkg-gourmet-tampered-rev6-log.tgz
Changes applied before test
commit db24c5eba543c871416500c7bd8ba79598a36ce0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 13:59:25 2020 +0200

    tests: Drop dead code
    
    Related to T2462

commit 01f9382e7442ef6510d016b7f7f42d6ac4c04b22
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 13:52:16 2020 +0200

    tests: Refactor repository with tampered information scenario
    
    This actually uses a real modified repository.
    
    Prior to this, this faked the alteration by modifying the input of the loader
    which is a hack.
    
    Related to T2462

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/64/ for more details.

This revision was automatically updated to reflect the committed changes.