Add function storage.algos.directory.directory_get
ClosedPublic
Actions

Authored by vlorentz on May 2 2022, 12:26 PM.

Details

Reviewers

Ericson2314
anlambert

Group Reviewers

Reviewers

Commits

rDSTO9562953493f5: Add function storage.algos.directory.directory_get

Summary

It will be used in swh-web to fetch a complete directory object,
ie. with the raw_manifest and all entries.

Replaces D7720 (same code but with better tests and renamed the function to be more accurate)

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.May 2 2022, 12:26 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 2 2022, 12:26 PM

vlorentz mentioned this in D7720: Add `algos.directory.directory_get_all_entries`.May 2 2022, 12:27 PM

Build is green

Patch application report for D7722 (id=27927)

Rebasing onto fb5514112d...

Current branch diff-target is up to date.

Changes applied before test

commit 9562953493f53ca6a10aad201285075d0a130a31
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon May 2 12:18:27 2022 +0200

    Add function storage.algos.directory.directory_get
    
    It will be used i swh-storage to fetch a complete directory object,
    ie. with the raw_manifest and all branches.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1603/ for more details.

Harbormaster completed remote builds in B28991: Diff 27927.May 2 2022, 12:37 PM

vlorentz requested review of this revision.May 2 2022, 12:37 PM

Oh awesome! Thank so much!!

This revision is now accepted and ready to land.May 2 2022, 4:29 PM

Looks good to me but there is a typo in commit message (s/i/in) and you should replace branches by entries in it.

This revision now requires changes to proceed.May 2 2022, 4:37 PM

Update commit message in the way @anlambert requested

Ericson2314 accepted this revision.May 2 2022, 6:56 PM

Ericson2314 edited the summary of this revision. (Show Details)

Build has FAILED

Patch application report for D7722 (id=27944)

Rebasing onto fb5514112d...

Current branch diff-target is up to date.

Changes applied before test

commit 6d0b4e86b4208fc87304a4192548e8e7d5eceab0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon May 2 12:49:26 2022 -0400

    Add function storage.algos.directory.directory_get
    
    It will be used in swh-web to fetch a complete directory object, i.e.
    with the raw_manifest and all entries.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1604/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1604/console

Harbormaster failed remote builds in B29017: Diff 27944!May 2 2022, 7:04 PM

anlambert accepted this revision.May 3 2022, 10:41 AM

This revision is now accepted and ready to land.May 3 2022, 10:41 AM

This revision was landed with ongoing or failed builds.May 3 2022, 11:32 AM

Closed by commit rDSTO9562953493f5: Add function storage.algos.directory.directory_get (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTO9562953493f5: Add function storage.algos.directory.directory_get.

vlorentz mentioned this in D7192: Route for fetching Git-encoded objects.May 3 2022, 1:24 PM