Page MenuHomeSoftware Heritage

Ericson2314 (John Ericson)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 6 2022, 10:47 PM (6 w, 4 d)

Recent Activity

Thu, May 5

Ericson2314 closed T4224: `/api/1/known/` returns wrong answers the SWHIDs only differ by object type as Resolved.

Fixed with D7748

Thu, May 5, 7:56 PM · Easy hack, Web app
Ericson2314 closed D7748: Fix `api_swhid_known` when swhids share hash part.
Thu, May 5, 7:39 PM
Ericson2314 committed rDWAPPS55122f0a2e29: Fix `api_swhid_known` when swhids share hash part (authored by Ericson2314).
Fix `api_swhid_known` when swhids share hash part
Thu, May 5, 7:39 PM
Ericson2314 updated the diff for D7748: Fix `api_swhid_known` when swhids share hash part.

Fix commit messsage as @vlorentz requested

Thu, May 5, 7:18 PM
Ericson2314 requested review of D7748: Fix `api_swhid_known` when swhids share hash part.
Thu, May 5, 6:46 PM
Ericson2314 claimed T4224: `/api/1/known/` returns wrong answers the SWHIDs only differ by object type.
Thu, May 5, 5:30 PM · Easy hack, Web app
Ericson2314 added a comment to T4224: `/api/1/known/` returns wrong answers the SWHIDs only differ by object type.

As I suspected, api_swhid_known in swh/web/api/views/identifiers.py does some keying by hashes, and that logic is not quite right :).

Thu, May 5, 5:23 PM · Easy hack, Web app
Ericson2314 created T4224: `/api/1/known/` returns wrong answers the SWHIDs only differ by object type.
Thu, May 5, 5:20 PM · Easy hack, Web app
Ericson2314 added inline comments to D7746: docs: Add /raw/(swhid)/ endpoint in Web API documentation.
Thu, May 5, 5:15 PM
Ericson2314 accepted D7746: docs: Add /raw/(swhid)/ endpoint in Web API documentation.
Thu, May 5, 5:14 PM

Wed, May 4

Ericson2314 added a comment to D7192: Route for fetching Git-encoded objects.

Ah. and I guess there needs to be another round of tagging and whatnot to trigger a website redeploy?

Wed, May 4, 12:20 AM

Tue, May 3

Ericson2314 added a comment to D7192: Route for fetching Git-encoded objects.

(Post merge, the diff that shows up is just the first commit, but they all are on master.)

Tue, May 3, 10:11 PM
Ericson2314 added a comment to D7192: Route for fetching Git-encoded objects.

Eh, I'll just assume, given the timezone latency, that going down to one review was intentional. (With the directory algorithm factored out into swh-storage, this patch is now simpler and more "just do the obvious thing" too.)

Tue, May 3, 10:09 PM
Ericson2314 committed rDWAPPS25a999821b3f: Adds an API route for fetching objects as Git objects (authored by plt-amy).
Adds an API route for fetching objects as Git objects
Tue, May 3, 10:08 PM
Ericson2314 closed D7192: Route for fetching Git-encoded objects.
Tue, May 3, 10:08 PM
Ericson2314 committed rDWAPPS43b197d8357f: Deduplicate `SWHID_RE` (authored by Ericson2314).
Deduplicate `SWHID_RE`
Tue, May 3, 10:08 PM
Ericson2314 committed rDWAPPS9cd95df4775c: Extend test utits with new functions (authored by Ericson2314).
Extend test utits with new functions
Tue, May 3, 10:08 PM
Ericson2314 added a comment to D7192: Route for fetching Git-encoded objects.

@vlorentz is anyone else (@anlambert?) going to review, or should I push this once it passes again?

Tue, May 3, 7:57 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Rebase as master changed since

Tue, May 3, 7:56 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Use new swh.storage.algos.directory.directory_get

Tue, May 3, 4:25 PM

Mon, May 2

Ericson2314 updated the summary of D7722: Add function storage.algos.directory.directory_get.
Mon, May 2, 6:57 PM
Ericson2314 accepted D7722: Add function storage.algos.directory.directory_get.
Mon, May 2, 6:56 PM
Ericson2314 updated the diff for D7722: Add function storage.algos.directory.directory_get.

Update commit message in the way @anlambert requested

Mon, May 2, 6:54 PM
Ericson2314 abandoned D7720: Add `algos.directory.directory_get_all_entries`.
Mon, May 2, 4:29 PM
Ericson2314 accepted D7722: Add function storage.algos.directory.directory_get.

Oh awesome! Thank so much!!

Mon, May 2, 4:29 PM
Ericson2314 added a comment to D7720: Add `algos.directory.directory_get_all_entries`.

Do you think it would be possible to land this, and a version of the main one that depends on this, and then circle back to add the additional tests for malformed objects?

Mon, May 2, 7:50 AM

Sun, May 1

Ericson2314 requested review of D7720: Add `algos.directory.directory_get_all_entries`.
Sun, May 1, 9:09 PM
Ericson2314 added inline comments to D7192: Route for fetching Git-encoded objects.
Sun, May 1, 8:08 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Include raw manifest in directory object

Sun, May 1, 7:20 PM
Ericson2314 added a comment to D7192: Route for fetching Git-encoded objects.

(Mark notes to fix copyright as done)

Sun, May 1, 7:16 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Fix copyright dates

Sun, May 1, 7:15 PM
Ericson2314 added a comment to D7192: Route for fetching Git-encoded objects.

Do you all know what is causing these CI failures?

just Cypress tests timing out as usual

Sun, May 1, 6:44 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Kick off CI again after I saw swh-model's wor

Sun, May 1, 6:31 PM
Ericson2314 closed D7719: Dedup `format_git_object_from_headers`.
Sun, May 1, 6:28 PM
Ericson2314 committed rDMODfe4ebb2f51aa: Dedup `format_git_object_from_headers` (authored by Ericson2314).
Dedup `format_git_object_from_headers`
Sun, May 1, 6:28 PM
Ericson2314 requested review of D7719: Dedup `format_git_object_from_headers`.
Sun, May 1, 5:40 PM

Fri, Apr 29

Ericson2314 added a comment to D7192: Route for fetching Git-encoded objects.

Do you all know what is causing these CI failures?

Fri, Apr 29, 5:50 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Push same stuff again to restart job

Fri, Apr 29, 6:15 AM

Thu, Apr 28

Ericson2314 added a comment to D7192: Route for fetching Git-encoded objects.

I'll wait for now pending @anlambert review, but let me know if I should push again to to trigger a new build after the last one seems to have died spuriously (if I am not misunderstanding).

Thu, Apr 28, 8:24 PM
Ericson2314 added inline comments to D7192: Route for fetching Git-encoded objects.
Thu, Apr 28, 7:32 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Remove dead code, remove 400 from docs

Thu, Apr 28, 7:31 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

It would seem I did a no-op revise before

Thu, Apr 28, 6:26 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Remove unused imports

Thu, Apr 28, 5:25 PM
Ericson2314 added inline comments to D7192: Route for fetching Git-encoded objects.
Thu, Apr 28, 5:24 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Address some review comments

Thu, Apr 28, 5:11 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

It works! Clean up commit history and stop filtering the tests

Thu, Apr 28, 12:57 AM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Try to fix without with_data

Thu, Apr 28, 12:37 AM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Try to fix content test with with_data

Thu, Apr 28, 12:15 AM

Wed, Apr 27

Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Try again to fix tests

Wed, Apr 27, 11:45 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Fix import of snapshot_get_all_branches

Wed, Apr 27, 11:17 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Fix some issues, use @vlorentz's suggestion to vastly simplify!

Wed, Apr 27, 11:10 PM
Ericson2314 added a comment to D7192: Route for fetching Git-encoded objects.

@vlorentz Thanks! That is much nice!

Wed, Apr 27, 10:51 PM
Ericson2314 abandoned D7705: Format `test_archive.py`.

My version of black was too old!

Wed, Apr 27, 10:44 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Try to fix tests

Wed, Apr 27, 10:15 PM
Ericson2314 requested review of D7705: Format `test_archive.py`.
Wed, Apr 27, 10:06 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Fix typo, I wasn't running flake8 on enough files!

Wed, Apr 27, 9:52 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.
  • Follow @vlorentz's advice to hopfully get mocking to work
Wed, Apr 27, 9:45 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Reuse storage from archive

Wed, Apr 27, 8:57 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Use storage directly rather than archive

Wed, Apr 27, 8:50 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Fix flake8 errors, fix messed up imports

Wed, Apr 27, 7:11 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Try new swh_model, unparse object_id

Wed, Apr 27, 7:01 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Fix url_args keys

Wed, Apr 27, 6:39 PM
Ericson2314 closed D7653: Add missing `content_git_object`.
Wed, Apr 27, 6:28 PM
Ericson2314 committed rDMOD08c69e63794a: Add missing `content_git_object` (authored by Ericson2314).
Add missing `content_git_object`
Wed, Apr 27, 6:28 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

-k in pytest.ini

Wed, Apr 27, 6:20 PM
Ericson2314 updated the diff for D7653: Add missing `content_git_object`.

Use git-style not phab-style commit message

Wed, Apr 27, 6:17 PM
Ericson2314 added a comment to D7653: Add missing `content_git_object`.

@vlorentz do you mean repeat the title in the summary field?

Wed, Apr 27, 5:54 PM
Ericson2314 updated the summary of D7653: Add missing `content_git_object`.
Wed, Apr 27, 5:51 PM
Ericson2314 added a comment to D7192: Route for fetching Git-encoded objects.

On a diferrent note, once D7653 lands is there any synchronization work, or can the next version of this just start using content_git_object right away?

Wed, Apr 27, 5:16 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Make URL param name and python param name align

Wed, Apr 27, 5:13 PM
Ericson2314 updated subscribers of D7192: Route for fetching Git-encoded objects.

Yeah I am afraid I haven not yet gotten the container setup instructions from @plt-amy (we are both on NixOS) and so I am flying blind (ab)using CI. I was already planning on doing that today, but in the meantime I might see if I can temp change CI just to run the one test :).

Wed, Apr 27, 5:11 PM
Ericson2314 added a comment to D7192: Route for fetching Git-encoded objects.

Ah thanks so much, @vlorentz! I was even looking for something along those lines, but just totally failed to find it.

Wed, Apr 27, 4:46 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Add swh/web/api/urls.py import, fix positional param name

Wed, Apr 27, 4:45 PM
Ericson2314 added a comment to D7192: Route for fetching Git-encoded objects.

django.urls.exceptions.NoReverseMatch: Reverse for 'api-1-raw-object' not found. 'api-1-raw-object' is not a valid view function or pattern name.

Wed, Apr 27, 12:34 AM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Fix flake8 asking for more blank lines

Wed, Apr 27, 12:04 AM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Fix api_route decoration, factor out SWHID_RE

Wed, Apr 27, 12:02 AM

Tue, Apr 26

Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Fix typo

Tue, Apr 26, 10:42 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Fix typo

Tue, Apr 26, 10:39 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Tweak some things

Tue, Apr 26, 10:36 PM
Ericson2314 added a comment to D7192: Route for fetching Git-encoded objects.

BTW, is there a way to convert one of these back to a "draft" state?

Tue, Apr 26, 10:17 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Fix flake8 issues

Tue, Apr 26, 10:16 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Fix CI failures

Tue, Apr 26, 10:07 PM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Try adding tests, simplify implementation

Tue, Apr 26, 9:59 PM
Ericson2314 planned changes to D7192: Route for fetching Git-encoded objects.
Tue, Apr 26, 9:58 PM
Ericson2314 commandeered D7192: Route for fetching Git-encoded objects.
Tue, Apr 26, 9:58 PM
Ericson2314 added a comment to D7653: Add missing `content_git_object`.

Thanks @vlorentz for all your advice and help. I think this is good now!

Tue, Apr 26, 8:55 PM
Ericson2314 updated the summary of D7653: Add missing `content_git_object`.
Tue, Apr 26, 8:53 PM
Ericson2314 requested review of D7653: Add missing `content_git_object`.
Tue, Apr 26, 8:52 PM
Ericson2314 added a comment to D7192: Route for fetching Git-encoded objects.

I suppose a next step is testing this?

Tue, Apr 26, 7:56 AM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Fix missing imports

Tue, Apr 26, 6:00 AM
Ericson2314 retitled D7192: Route for fetching Git-encoded objects from Route for fetching Git-encoded snapshots to Route for fetching Git-encoded objects.
Tue, Apr 26, 4:56 AM
Ericson2314 updated the diff for D7192: Route for fetching Git-encoded objects.

Convert to follow mailing list plan

Tue, Apr 26, 4:54 AM

Apr 6 2022

Ericson2314 added a comment to D7192: Route for fetching Git-encoded objects.

So in https://github.com/obsidiansystems/go-ipfs-swh-plugin/blob/66272b4a7d903171e2a1dd3d75309b3c1cad5ece/bridge/bridge.go#L119-L155 you can see how we are using the content route today. Hopefully seeing some working code makes things clearer!

Apr 6 2022, 10:58 PM