It will be used in swh-web to fetch a complete directory object,
ie. with the raw_manifest and all entries.
Replaces D7720 (same code but with better tests and renamed the function to be more accurate)
Details
Details
- Reviewers
Ericson2314 anlambert - Group Reviewers
Reviewers - Commits
- rDSTO9562953493f5: Add function storage.algos.directory.directory_get
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Branch
- directory_get
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 28991 Build 45323: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 45322: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D7722 (id=27927)
Rebasing onto fb5514112d...
Current branch diff-target is up to date.
Changes applied before test
commit 9562953493f53ca6a10aad201285075d0a130a31
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon May 2 12:18:27 2022 +0200
Add function storage.algos.directory.directory_get
It will be used i swh-storage to fetch a complete directory object,
ie. with the raw_manifest and all branches.See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1603/ for more details.
Comment Actions
Looks good to me but there is a typo in commit message (s/i/in) and you should replace branches by entries in it.
Comment Actions
Build has FAILED
Patch application report for D7722 (id=27944)
Rebasing onto fb5514112d...
Current branch diff-target is up to date.
Changes applied before test
commit 6d0b4e86b4208fc87304a4192548e8e7d5eceab0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon May 2 12:49:26 2022 -0400
Add function storage.algos.directory.directory_get
It will be used in swh-web to fetch a complete directory object, i.e.
with the raw_manifest and all entries.Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1604/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1604/console