There isn't yet a separate test_directories because the infrastructure
in swh.model.hypothesis.strategies doesn't not exist yet. But there
was an existing test where we could use this.
Details
Details
- Reviewers
- None
- Group Reviewers
Reviewers
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Branch
- directory-algo
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 28989 Build 45319: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 45318: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D7720 (id=27923)
Rebasing onto fb5514112d...
Current branch diff-target is up to date.
Changes applied before test
commit 1ae734d0d9d0501d584728e19fed6bc3e3228921
Author: John Ericson <John.Ericson@Obsidian.Systems>
Date: Sun May 1 13:48:10 2022 -0400
Add `algos.directory.directory_get_all_entries`
There isn't yet a separate `test_directories` because the infrastructure
in `swh.model.hypothesis.strategies` doesn't not exist yet. But there
was an existing test where we could use this.Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1600/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1600/console
Comment Actions
Build has FAILED
Patch application report for D7720 (id=27924)
Rebasing onto fb5514112d...
Current branch diff-target is up to date.
Changes applied before test
commit 95c7b5f1f7d5a26cc70282663827a0e6b8805492
Author: John Ericson <John.Ericson@Obsidian.Systems>
Date: Sun May 1 13:48:10 2022 -0400
Add `algos.directory.directory_get_all_entries`
Summary:
There isn't yet a separate `test_directories` because the infrastructure
in `swh.model.hypothesis.strategies` doesn't not exist yet. But there
was an existing test where we could use this.
Reviewers: #reviewers
Differential Revision: https://forge.softwareheritage.org/D7720Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1601/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1601/console
Comment Actions
Build is green
Patch application report for D7720 (id=27925)
Rebasing onto fb5514112d...
Current branch diff-target is up to date.
Changes applied before test
commit 10ff8e430fed82cc7583273dd1e6f49be8febc82
Author: John Ericson <John.Ericson@Obsidian.Systems>
Date: Sun May 1 13:48:10 2022 -0400
Add `algos.directory.directory_get_all_entries`
Summary:
There isn't yet a separate `test_directories` because the infrastructure
in `swh.model.hypothesis.strategies` doesn't not exist yet. But there
was an existing test where we could use this.
Reviewers: #reviewers
Differential Revision: https://forge.softwareheritage.org/D7720See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1602/ for more details.
Comment Actions
Good idea.
Regarding tests, avoid using hypothesis for new tests outside swh-web, it's slow and not reliable.
Instead, you should make tests insert objects directly in the storage
Comment Actions
Do you think it would be possible to land this, and a version of the main one that depends on this, and then circle back to add the additional tests for malformed objects?
That would unblock the remaining work on the IPFS side so we can do more in parallel.
I opened this one right away because I figured it is more of a pain of move around code than just get what goes where right the first time, but additional tests I do think are easy enough to add incrementally.