Page MenuHomeSoftware Heritage
Differential D767

storage.in_memory: Use integer ids for origin and visit instead of tuples
ClosedPublic
Actions

Authored by anlambert on Dec 4 2018, 1:36 PM.

Details

Reviewers
vlorentz
Commits
rDSTOCd5e8229fb18e: storage.in_memory: Use integer ids for origin and visit instead of tuples
R65:d5e8229fb18e: storage.in_memory: Use integer ids for origin and visit instead of tuples
rDSTOd5e8229fb18e: storage.in_memory: Use integer ids for origin and visit instead of tuples
Summary

In order to match the real storage api and ease the drop of swh-storage
mocking used in a large amount of tests, use integer ids for origin
and visit instead of tuples.

Related T1421

Diff Detail

Repository
rDSTO Storage manager
Branch
origin-visit-int-id
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2810
Build 3533: tox-on-jenkinsJenkins
Build 3532: arc lint + arc unit

Event Timeline

anlambert created this revision.Dec 4 2018, 1:36 PM
anlambert added a child revision: D768: tests: Use in-memory storage instead of mocking it.Dec 4 2018, 1:39 PM
swh-public-ci added a subscriber: swh-public-ci.Dec 4 2018, 1:41 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/129/ for more details.

Harbormaster completed remote builds in B2805: Diff 2409.Dec 4 2018, 1:41 PM
vlorentz accepted this revision.Dec 4 2018, 2:12 PM
vlorentz added inline comments.
swh/storage/in_memory.py
564–570

D769

661

sort by date + test case

803–804

add comment

838

sorting not needed

This revision is now accepted and ready to land.Dec 4 2018, 2:12 PM
anlambert updated this revision to Diff 2412.Dec 4 2018, 3:06 PM

Update: Address vlorentz comments

swh-public-ci added a comment.Dec 4 2018, 3:11 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/135/ for more details.

Harbormaster completed remote builds in B2809: Diff 2412.Dec 4 2018, 3:11 PM
anlambert updated this revision to Diff 2413.Dec 4 2018, 3:27 PM

Update: Improve some docstrings

swh-public-ci added a comment.Dec 4 2018, 3:32 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/136/ for more details.

Harbormaster completed remote builds in B2810: Diff 2413.Dec 4 2018, 3:32 PM
anlambert updated this revision to Diff 2416.Dec 4 2018, 4:00 PM

Update: rebase

vlorentz accepted this revision.Dec 4 2018, 4:01 PM
swh-public-ci added a comment.Dec 4 2018, 4:06 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/137/ for more details.

Harbormaster completed remote builds in B2815: Diff 2416.Dec 4 2018, 4:06 PM
Closed by commit rDSTOd5e8229fb18e: storage.in_memory: Use integer ids for origin and visit instead of tuples (authored by anlambert). · Explain WhyDec 4 2018, 4:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
storage/
202 lines
tests/
11 lines

Diff 2413

View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal