Page MenuHomeSoftware Heritage

storage.in_memory: Use integer ids for origin and visit instead of tuples
ClosedPublic

Authored by anlambert on Dec 4 2018, 1:36 PM.

Details

Summary

In order to match the real storage api and ease the drop of swh-storage
mocking used in a large amount of tests, use integer ids for origin
and visit instead of tuples.

Related T1421

Diff Detail

Repository
rDSTO Storage manager
Branch
origin-visit-int-id
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2805
Build 3524: tox-on-jenkinsJenkins
Build 3523: arc lint + arc unit

Event Timeline

vlorentz added inline comments.
swh/storage/in_memory.py
561–562
656

sort by date + test case

798

add comment

832

sorting not needed

This revision is now accepted and ready to land.Dec 4 2018, 2:12 PM

Update: Address vlorentz comments

Update: Improve some docstrings

This revision was automatically updated to reflect the committed changes.