Page MenuHomeSoftware Heritage

storage.in_memory: Use integer ids for origin and visit instead of tuples
ClosedPublic

Authored by anlambert on Tue, Dec 4, 1:36 PM.

Details

Summary

In order to match the real storage api and ease the drop of swh-storage
mocking used in a large amount of tests, use integer ids for origin
and visit instead of tuples.

Related T1421

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Tue, Dec 4, 1:36 PM
vlorentz accepted this revision.Tue, Dec 4, 2:12 PM
vlorentz added inline comments.
swh/storage/in_memory.py
564–570
662

sort by date + test case

803–804

add comment

839

sorting not needed

This revision is now accepted and ready to land.Tue, Dec 4, 2:12 PM
anlambert updated this revision to Diff 2412.Tue, Dec 4, 3:06 PM

Update: Address vlorentz comments

anlambert updated this revision to Diff 2413.Tue, Dec 4, 3:27 PM

Update: Improve some docstrings

anlambert updated this revision to Diff 2416.Tue, Dec 4, 4:00 PM

Update: rebase

vlorentz accepted this revision.Tue, Dec 4, 4:01 PM
This revision was automatically updated to reflect the committed changes.