Page MenuHomeSoftware Heritage

sourceforge: Fix origin URLs for CVS projects
ClosedPublic

Authored by anlambert on Feb 16 2022, 11:39 AM.

Details

Summary

CVS projects are different from other VCS ones, they use the rsync
protocol, a list of modules needs to be fetched from an info page
and multiple origin URLs can be produced for a same project.

Related to T3789

Diff Detail

Repository
rDLS Listers
Branch
sourceforge-lister-cvs-fix
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26895
Build 42044: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 42043: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D7186 (id=26025)

Rebasing onto 31b4429ced...

Current branch diff-target is up to date.
Changes applied before test
commit d709a47e89a559d972b5145bb2af8eeaa2ad3c39
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Feb 15 22:16:45 2022 +0100

    sourceforge: Fix origin URLs for CVS projects
    
    CVS projects are different from other VCS ones, they use the rsync
    protocol, a list of modules needs to be fetched from an info page
    and multiple origin URLs can be produced for a same project.
    
    Related to T3789

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/452/ for more details.

ardumont added a reviewer: stsp. ardumont added 1 blocking reviewer(s): Reviewers.
ardumont added a subscriber: ardumont.

lgtm

swh/lister/sourceforge/lister.py
372

bump that to an error level?

swh/lister/sourceforge/lister.py
372

I can bump to logger.warning yes.

Bump log from debug to warning.

Build is green

Patch application report for D7186 (id=26028)

Rebasing onto 31b4429ced...

Current branch diff-target is up to date.
Changes applied before test
commit 7f18f6a65f8d70a3e027414be7c831ea2115612e
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Feb 15 22:16:45 2022 +0100

    sourceforge: Fix origin URLs for CVS projects
    
    CVS projects are different from other VCS ones, they use the rsync
    protocol, a list of modules needs to be fetched from an info page
    and multiple origin URLs can be produced for a same project.
    
    Related to T3789

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/453/ for more details.

Build is green

Patch application report for D7186 (id=26088)

Rebasing onto 4265e5dd77...

Current branch diff-target is up to date.
Changes applied before test
commit 6a7479553e6be3a84790001c150bba39be44864d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Feb 15 22:16:45 2022 +0100

    sourceforge: Fix origin URLs for CVS projects
    
    CVS projects are different from other VCS ones, they use the rsync
    protocol, a list of modules needs to be fetched from an info page
    and multiple origin URLs can be produced for a same project.
    
    Related to T3789

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/462/ for more details.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 17 2022, 1:55 PM
This revision was automatically updated to reflect the committed changes.