Page MenuHomeSoftware Heritage

Add method 'TimestampWithTimezone.offset_minutes'
ClosedPublic

Authored by vlorentz on Jan 21 2022, 12:53 PM.

Details

Summary

A future commit will remove the 'offset' attribute, and rename
'offset_bytes' to 'offset'.

Modules using the .offset attribute will need to switch to this new
method to keep working.

Diff Detail

Repository
rDMOD Data model
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26244
Build 41028: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 41027: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D7005 (id=25401)

Rebasing onto f43f9ac98c...

Current branch diff-target is up to date.
Changes applied before test
commit a654060bf246aa8dc2a40cceaf86ea449f55068c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jan 21 12:47:58 2022 +0100

    Add method 'TimestampWithTimezone.offset_minutes'
    
    A future commit will remove the 'offset' attribute, and rename
    'offset_bytes' to 'offset'.
    
    Modules using the `.offset` attribute will need to switch to this new
    method to keep working.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/453/ for more details.

olasd added a subscriber: olasd.

Sounds good to me, thanks!

This revision is now accepted and ready to land.Jan 21 2022, 1:39 PM