Page MenuHomeSoftware Heritage

Use swh.model.model helpers to compute object identifiers
ClosedPublic

Authored by olasd on Thu, Oct 15, 11:52 AM.

Details

Summary

This will allow us to change the signature of the swh.model.identifiers
functions to use model objects directly instead of dicts.

Test Plan

tox

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Thu, Oct 15, 11:52 AM

Build is green

Patch application report for D4266 (id=15081)

Rebasing onto eb077d9cb6...

Current branch diff-target is up to date.
Changes applied before test
commit fe24413f668c5946e56cc63c95fcee7cd980d4b2
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Oct 15 11:45:54 2020 +0200

    Use swh.model.model helpers to compute object identifiers
    
    This will allow us to change the signature of the `swh.model.identifiers`
    functions to use model objects directly instead of dicts.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/411/ for more details.

ardumont accepted this revision.Thu, Oct 15, 12:01 PM
ardumont added a subscriber: ardumont.

That's also clearer.

This revision is now accepted and ready to land.Thu, Oct 15, 12:01 PM