swh-web: Migrate to new storage.origin_visit_add endpoint
ClosedPublic
Actions

Authored by ardumont on Jun 11 2020, 7:11 PM.

Details

Reviewers

vlorentz
anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T2310: Make origin visits immutable

Commits

rDWAPPSdc25295b05fa: Migrate to new storage.origin_visit_add endpoint

Summary

Depends on D3262 (storage)
Depends on D3264 (loader-core)
Related to T2310

Test Plan

tox

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 12788
Build 19457: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 19456: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	0 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.test_utils .tox/py3/lib/python3.7/site-packages/swh/web/tests/api/test_utils.py:112: in <module> @given(release()) .tox/py3/lib/python3.7/site-packages/swh/web/tests/strategies.py:337: in release
	0 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_content .tox/py3/lib/python3.7/site-packages/swh/web/tests/api/views/test_content.py:16: in <module> @given(content()) .tox/py3/lib/python3.7/site-packages/swh/web/tests/strategies.py:87: in content
	0 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_directory .tox/py3/lib/python3.7/site-packages/swh/web/tests/api/views/test_directory.py:16: in <module> @given(directory()) .tox/py3/lib/python3.7/site-packages/swh/web/tests/strategies.py:210: in directory
	0 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_identifiers .tox/py3/lib/python3.7/site-packages/swh/web/tests/api/views/test_identifiers.py:27: in <module> @given(origin(), content(), directory(), release(), revision(), snapshot()) .tox/py3/lib/python3.7/site-packages/swh/web/tests/strategies.py:256: in origin
	0 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_origin .tox/py3/lib/python3.7/site-packages/swh/web/tests/api/views/test_origin.py:366: in <module> @given(origin()) .tox/py3/lib/python3.7/site-packages/swh/web/tests/strategies.py:256: in origin
		View Full Test Results (19 Failed)

Event Timeline

ardumont created this revision.Jun 11 2020, 7:11 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 11 2020, 7:11 PM

ardumont added inline comments.Jun 11 2020, 7:13 PM

swh/web/tests/data.py
141	This is actually related through the loader change which imposes the datetime type now. Related to D3264

Build has FAILED

Patch application report for D3267 (id=11583)

Rebasing onto de0dfcb3b5...

First, rewinding head to replay your work on top of it...
Applying: Migrate to new storage.origin_visit_add endpoint

Changes applied before test

commit cbad6cc6b6ee3279a1271521a4eee4034f7ae16a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jun 11 19:10:55 2020 +0200

    Migrate to new storage.origin_visit_add endpoint
    
    Related to T2310

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/170/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/170/console

Harbormaster failed remote builds in B12788: Diff 11583!Jun 11 2020, 7:26 PM

vlorentz accepted this revision.Jun 11 2020, 8:17 PM

This revision is now accepted and ready to land.Jun 11 2020, 8:17 PM

Build has FAILED

Patch application report for D3267 (id=11583)

Rebasing onto de0dfcb3b5...

First, rewinding head to replay your work on top of it...
Applying: Migrate to new storage.origin_visit_add endpoint

Changes applied before test

commit 71761c1967083bbc0f677caf011576e364c7b4fc
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jun 11 19:10:55 2020 +0200

    Migrate to new storage.origin_visit_add endpoint
    
    Related to T2310

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/176/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/176/console

ardumont edited the summary of this revision. (Show Details)Jun 12 2020, 10:12 AM

ardumont edited the test plan for this revision. (Show Details)

ardumont added a parent revision: D3264: Migrate to new storage.origin_visit_add endpoint.

Thanks !

ardumont mentioned this in T2310: Make origin visits immutable.Jun 12 2020, 11:05 AM

ardumont edited the test plan for this revision. (Show Details)

Avoid unnecessary affectation instructions

(unsure whether the build will pass as the dependency required is loader-git
and not loader-core though, let's see ;).

ardumont edited the test plan for this revision. (Show Details)Jun 12 2020, 11:19 AM

Build is green

Patch application report for D3267 (id=11593)

Rebasing onto de0dfcb3b5...

First, rewinding head to replay your work on top of it...
Applying: Migrate to new storage.origin_visit_add endpoint

Changes applied before test

commit e6e2783d9b12adeb557fa89e64869a2c9c109a47
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jun 11 19:10:55 2020 +0200

    Migrate to new storage.origin_visit_add endpoint
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/177/ for more details.

Harbormaster completed remote builds in B12798: Diff 11593.Jun 12 2020, 11:24 AM

(unsure whether the build will pass as the dependency required is loader-git
and not loader-core though, let's see ;).

well, it's fine then heh ;)

In D3267#79830, @ardumont wrote:

(unsure whether the build will pass as the dependency required is loader-git
and not loader-core though, let's see ;).

well, it's fine then heh ;)

Yes, tests run fine locally after updating storage and loader-core :-)

Rebase on latest master

Build is green

Patch application report for D3267 (id=11596)

Rebasing onto de0dfcb3b5...

Current branch diff-target is up to date.

Changes applied before test

commit dc25295b05fae364eca3b741f6bf0055f52f0341
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jun 11 19:10:55 2020 +0200

    Migrate to new storage.origin_visit_add endpoint
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/178/ for more details.

Harbormaster completed remote builds in B12801: Diff 11596.Jun 12 2020, 11:37 AM

Closed by commit rDWAPPSdc25295b05fa: Migrate to new storage.origin_visit_add endpoint (authored by ardumont). · Explain WhyJun 12 2020, 11:38 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDWAPPSdc25295b05fa: Migrate to new storage.origin_visit_add endpoint.