Page MenuHomeSoftware Heritage

swh-web: Migrate to new storage.origin_visit_add endpoint
ClosedPublic

Authored by ardumont on Jun 11 2020, 7:11 PM.

Details

Summary

Depends on D3262 (storage)
Depends on D3264 (loader-core)
Related to T2310

Test Plan

tox

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

swh/web/tests/data.py
140

This is actually related through the loader change which imposes the datetime type now.
Related to D3264

Build has FAILED

Patch application report for D3267 (id=11583)

Rebasing onto de0dfcb3b5...

First, rewinding head to replay your work on top of it...
Applying: Migrate to new storage.origin_visit_add endpoint
Changes applied before test
commit cbad6cc6b6ee3279a1271521a4eee4034f7ae16a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jun 11 19:10:55 2020 +0200

    Migrate to new storage.origin_visit_add endpoint
    
    Related to T2310

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/170/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/170/console

This revision is now accepted and ready to land.Jun 11 2020, 8:17 PM

Build has FAILED

Patch application report for D3267 (id=11583)

Rebasing onto de0dfcb3b5...

First, rewinding head to replay your work on top of it...
Applying: Migrate to new storage.origin_visit_add endpoint
Changes applied before test
commit 71761c1967083bbc0f677caf011576e364c7b4fc
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jun 11 19:10:55 2020 +0200

    Migrate to new storage.origin_visit_add endpoint
    
    Related to T2310

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/176/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/176/console

ardumont edited the test plan for this revision. (Show Details)

Avoid unnecessary affectation instructions

(unsure whether the build will pass as the dependency required is loader-git
and not loader-core though, let's see ;).

Build is green

Patch application report for D3267 (id=11593)

Rebasing onto de0dfcb3b5...

First, rewinding head to replay your work on top of it...
Applying: Migrate to new storage.origin_visit_add endpoint
Changes applied before test
commit e6e2783d9b12adeb557fa89e64869a2c9c109a47
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jun 11 19:10:55 2020 +0200

    Migrate to new storage.origin_visit_add endpoint
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/177/ for more details.

(unsure whether the build will pass as the dependency required is loader-git
and not loader-core though, let's see ;).

well, it's fine then heh ;)

(unsure whether the build will pass as the dependency required is loader-git
and not loader-core though, let's see ;).

well, it's fine then heh ;)

Yes, tests run fine locally after updating storage and loader-core :-)

ardumont edited the test plan for this revision. (Show Details)

Rebase on latest master

Build is green

Patch application report for D3267 (id=11596)

Rebasing onto de0dfcb3b5...

Current branch diff-target is up to date.
Changes applied before test
commit dc25295b05fae364eca3b741f6bf0055f52f0341
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jun 11 19:10:55 2020 +0200

    Migrate to new storage.origin_visit_add endpoint
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/178/ for more details.