Differential D3264

Migrate to new storage.origin_visit_add endpoint
ClosedPublic
Actions

Authored by ardumont on Jun 11 2020, 6:57 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDLDBASE3df7462ad700: Migrate to new storage.origin_visit_add endpoint

Summary

This makes use of the latest origin_visit_add endpoint (which takes an iterable of OriginVisit)

The visit_date can no longer be a string so this also deals with it.
The cli still allows to input a visit_date as string though.

Depends on D3262 (storage)

Test Plan

tox

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jun 11 2020, 6:57 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 11 2020, 6:57 PM

Build has FAILED

Patch application report for D3264 (id=11579)

Rebasing onto 65eb70d7b7...

Current branch diff-target is up to date.

Changes applied before test

commit 2eccebf4220adeea0c6fbac49b1200ff27d0b9f8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jun 11 17:39:24 2020 +0200

    Migrate to new storage.origin_visit_add endpoint

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/68/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/68/console

Harbormaster failed remote builds in B12784: Diff 11579!Jun 11 2020, 6:57 PM

ardumont mentioned this in D3267: swh-web: Migrate to new storage.origin_visit_add endpoint.Jun 11 2020, 7:13 PM

vlorentz accepted this revision.Jun 11 2020, 8:10 PM

This revision is now accepted and ready to land.Jun 11 2020, 8:10 PM

visit_date can no longer be an Option[str, datetime.datetime]
Ensure we still can load visit_date as string through cli though

Build is green

Patch application report for D3264 (id=11589)

Rebasing onto 65eb70d7b7...

Current branch diff-target is up to date.

Changes applied before test

commit 3df7462ad700cd6136238fc75817f896afbce440
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jun 11 17:39:24 2020 +0200

    Migrate to new storage.origin_visit_add endpoint
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/69/ for more details.

Harbormaster completed remote builds in B12794: Diff 11589.Jun 12 2020, 9:56 AM

ardumont edited the summary of this revision. (Show Details)Jun 12 2020, 9:56 AM

ardumont edited the test plan for this revision. (Show Details)

ardumont added a child revision: D3267: swh-web: Migrate to new storage.origin_visit_add endpoint.Jun 12 2020, 10:12 AM

Closed by commit rDLDBASE3df7462ad700: Migrate to new storage.origin_visit_add endpoint (authored by ardumont). · Explain WhyJun 12 2020, 11:04 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDBASE3df7462ad700: Migrate to new storage.origin_visit_add endpoint.

ardumont mentioned this in T2310: Make origin visits immutable.Jun 12 2020, 11:05 AM