Details
- Reviewers
olasd vlorentz - Group Reviewers
Reviewers - Commits
- rDCIDX3125d9e9d8b8: indexer.cli.journal_client: Simplify the journal client call
tox
Diff Detail
- Repository
- rDCIDX Metadata indexer
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 11409 Build 17275: tox-on-jenkins Jenkins Build 17274: arc lint + arc unit
Event Timeline
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/724/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/724/console
| swh/indexer/cli.py | ||
|---|---|---|
| 225–227 | To be useful, I think that logging should be happening at the worker_fn level rather than outside of the call to client.process(). This means you can drop the last_log_time logic altogether. | |
Adapt according to review
Tests should be green now as the journal got releases with the necessary changes.
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/725/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/725/console
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/726/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/726/console
yes, indeed, i was on it ;)
(i forgot to run locally prior to pushing so i missed it).
Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/727/ for more details.