ardumont retitled this revision from cli: Rename --max-messages to --stop-after-objects to swh-search: cli: Rename --max-messages to --stop-after-objects (ci: unstuck master build).Mar 27 2020, 7:14 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSEA/job/tox/34/ for more details.

Harbormaster completed remote builds in B11389: Diff 10307.Mar 27 2020, 7:16 AM

ardumont edited the summary of this revision. (Show Details)Mar 27 2020, 7:17 AM

ardumont retitled this revision from swh-search: cli: Rename --max-messages to --stop-after-objects (ci: unstuck master build) to (ci: unstuck master build) swh-search: cli: Rename --max-messages to --stop-after-objects.Mar 27 2020, 7:36 AM

ardumont edited the summary of this revision. (Show Details)

ardumont retitled this revision from (ci: unstuck master build) swh-search: cli: Rename --max-messages to --stop-after-objects to (ci: unstuck master build) search: cli: Rename --max-messages to --stop-after-objects.Mar 27 2020, 7:46 AM

Thanks for trying to fix this. A few comments inline regarding the JournalClient usage pattern.

swh/search/cli.py
67–69	`client.process` does not need an outer loop, it handles that itself.
73–75	Please add a `finally: client.close()` clause so that the client properly shuts down (ref. `swh.journal.cli`)

This revision now requires changes to proceed.Mar 27 2020, 9:26 AM

Right, i forgot to check but i remembered something about that.
I'll also adapt the indexer's journal client which does something similar as this diff (without your remarks applied i mean)

ardumont mentioned this in D2901: tests.utils: Test from modules using this need to call close method.Mar 27 2020, 9:46 AM

Adapt according to review

Needs D2901 for the tests to go green

olasd accepted this revision.Mar 27 2020, 9:59 AM

This revision is now accepted and ready to land.Mar 27 2020, 9:59 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSEA/job/tox/35/
See console output for more information: https://jenkins.softwareheritage.org/job/DSEA/job/tox/35/console

Harbormaster failed remote builds in B11397: Diff 10317!Mar 27 2020, 10:00 AM

ardumont mentioned this in D2902: indexer.cli.journal_client: Simplify the journal client call.Mar 27 2020, 10:25 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSEA/job/tox/36/ for more details.

Harbormaster completed remote builds in B11397: Diff 10317.Mar 27 2020, 10:56 AM

Closed by commit rDSEA864f86c9bd2d: cli.journal_client: Adapt according to latest journal client change (authored by ardumont). · Explain WhyMar 27 2020, 10:57 AM