Paths

Table of Contentst

Differential D2901

tests.utils: Test from modules using this need to call close method
ClosedPublic
Actions

Authored by ardumont on Mar 27 2020, 9:46 AM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDJNLe6b1cb71f4e7: tests.utils: Test from modules using this need to call close method

Summary

This allows the clients to be written properly and their tests to pass.

To allow to write properly the swh.search client journal (which needs to call close when done).
and its test to pass.

Related to D2897

Depends on D2898

Test Plan

tox

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mar 27 2020, 9:46 AM

ardumont edited the summary of this revision. (Show Details)Mar 27 2020, 9:49 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/416/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/416/console

Harbormaster failed remote builds in B11396: Diff 10316!Mar 27 2020, 9:51 AM

ardumont edited the summary of this revision. (Show Details)Mar 27 2020, 9:55 AM

ardumont added a parent revision: D2898: (ci: fix master build) journal.tests: Adapt model according to latest change.

olasd accepted this revision.Mar 27 2020, 9:57 AM

This revision is now accepted and ready to land.Mar 27 2020, 9:57 AM

ardumont mentioned this in D2897: (ci: unstuck master build) search: cli: Rename --max-messages to --stop-after-objects.Mar 27 2020, 9:58 AM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/417/ for more details.

Harbormaster completed remote builds in B11396: Diff 10316.Mar 27 2020, 10:00 AM

Closed by commit rDJNLe6b1cb71f4e7: tests.utils: Test from modules using this need to call close method (authored by ardumont). · Explain WhyMar 27 2020, 10:11 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDJNLe6b1cb71f4e7: tests.utils: Test from modules using this need to call close method.

ardumont mentioned this in D2902: indexer.cli.journal_client: Simplify the journal client call.Mar 27 2020, 10:25 AM

Revision Contents
Changeset List

Path

Size

swh/

journal/

tests/

utils.py

3 lines

Diff 10320

View Options

swh/journal/tests/utils.py

tests.utils: Test from modules using this need to call close methodClosedPublicActions