Page MenuHomeSoftware Heritage
Differential D2902

indexer.cli.journal_client: Simplify the journal client call
ClosedPublic
Actions

Authored by ardumont on Mar 27 2020, 10:25 AM.

Details

Reviewers
olasd
vlorentz
Group Reviewers
Reviewers
Commits
rDCIDX3125d9e9d8b8: indexer.cli.journal_client: Simplify the journal client call
Summary

This aligns with other journal clients.
This lets the main loop being done by the journal client base class.

Related to D2897

Needs D2901 (released) for test to pass

Test Plan

tox

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mar 27 2020, 10:25 AM
swh-public-ci added a comment.Mar 27 2020, 10:28 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/724/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/724/console

Harbormaster failed remote builds in B11402: Diff 10322!Mar 27 2020, 10:28 AM
olasd requested changes to this revision.Mar 27 2020, 10:32 AM
olasd added inline comments.
swh/indexer/cli.py
225–227

To be useful, I think that logging should be happening at the worker_fn level rather than outside of the call to client.process(). This means you can drop the last_log_time logic altogether.

This revision now requires changes to proceed.Mar 27 2020, 10:32 AM
ardumont updated this revision to Diff 10328.Mar 27 2020, 11:00 AM

Adapt according to review

Tests should be green now as the journal got releases with the necessary changes.

ardumont updated this revision to Diff 10329.Mar 27 2020, 11:00 AM

Add missing requirements update on journal

olasd accepted this revision.Mar 27 2020, 11:02 AM
This revision is now accepted and ready to land.Mar 27 2020, 11:02 AM
swh-public-ci added a comment.Mar 27 2020, 11:02 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/725/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/725/console

Harbormaster failed remote builds in B11409: Diff 10328!Mar 27 2020, 11:02 AM
olasd added a comment.Mar 27 2020, 11:03 AM

(tests need an update for the new logging output)

swh-public-ci added a comment.Mar 27 2020, 11:05 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/726/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/726/console

Harbormaster failed remote builds in B11410: Diff 10329!Mar 27 2020, 11:05 AM
ardumont added a comment.EditedMar 27 2020, 11:06 AM

yes, indeed, i was on it ;)
(i forgot to run locally prior to pushing so i missed it).

ardumont updated this revision to Diff 10330.Mar 27 2020, 11:08 AM

Fix missing test adaptation

swh-public-ci added a comment.Mar 27 2020, 11:10 AM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/727/ for more details.

Harbormaster completed remote builds in B11411: Diff 10330.Mar 27 2020, 11:10 AM
Closed by commit rDCIDX3125d9e9d8b8: indexer.cli.journal_client: Simplify the journal client call (authored by ardumont). · Explain WhyMar 27 2020, 11:11 AM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDCIDX3125d9e9d8b8: indexer.cli.journal_client: Simplify the journal client call.

Revision Contents
Changeset List

PathSize
2 lines
swh/
indexer/
13 lines
tests/
3 lines

Diff 10331

View Options

requirements-swh.txt

Loading...
View Options

swh/indexer/cli.py

Loading...
View Options

swh/indexer/tests/test_cli.py

Loading...
About · Developer information · Legal