Page MenuHomeSoftware Heritage

(ci: fix master build) journal.tests: Adapt model according to latest change
ClosedPublic

Authored by ardumont on Mar 27 2020, 7:35 AM.

Details

Summary

origin model no longer allows to have type.

Related to f533f62bbf114cfcc29f7c72307c4dfbe99cf048

This will fix the current broken master build [1]

Similar to D2883
Related to D2815

[1] https://jenkins.softwareheritage.org/job/DJNL/job/tests/785/

Test Plan

tox

Diff Detail

Repository
rDJNL Journal infrastructure
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11390
Build 17246: tox-on-jenkinsJenkins
Build 17245: arc lint + arc unit

Event Timeline

ardumont retitled this revision from (ci: fix master build) swh.journal: tests: Adapt model according to latest change to (ci: fix master build) journal.tests: Adapt model according to latest change.Mar 27 2020, 7:47 AM
This revision is now accepted and ready to land.Mar 27 2020, 9:26 AM
This revision now requires review to proceed.Mar 27 2020, 9:27 AM

Oops, sorry, I thought of something.

I think we need an origin fixer to drop the potential types in the origin topic instead. @vlorentz, what do you think?

Oops, sorry, I thought of something.

I think we need an origin fixer to drop the potential types in the origin topic instead. @vlorentz, what do you think?

I thought it was already there...
so something is off somewhere indeed.

Oops, sorry, I thought of something.

I think we need an origin fixer to drop the potential types in the origin topic instead. @vlorentz, what do you think?

I thought it was already there...
so something is off somewhere indeed.

It's on origin_visit [1], not origin.
So yeah, probably as you mentioned, we need one.

[1] https://forge.softwareheritage.org/source/swh-journal/browse/master/swh/journal/fixer.py$236-239

This revision was not accepted when it landed; it landed in state Needs Review.Mar 27 2020, 10:11 AM
This revision was automatically updated to reflect the committed changes.

oops, i pushed that diff by mistake.
i think arcanist did more than what i asked... (well, what i had anticipated more like).

Still, i'll fix correctly the origin with a fixer in another diff.