Page MenuHomeSoftware Heritage

test: Adapt origin validation test according to latest model changes
ClosedPublic

Authored by ardumont on Thu, Mar 26, 10:58 AM.

Details

Summary

Origin model no longer allows to have a type.

Test will work if the new swh.model is tagged (and successfully uploaded to pypi)

Related to f533f62bbf114cfcc29f7c72307c4dfbe99cf048

Test Plan

tox

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Thu, Mar 26, 10:58 AM
vlorentz requested changes to this revision.Thu, Mar 26, 11:00 AM

It tests for the missing url, so it's still relevant.

This revision now requires changes to proceed.Thu, Mar 26, 11:00 AM
ardumont updated this revision to Diff 10268.Thu, Mar 26, 11:08 AM

Fix properly the test

vlorentz accepted this revision.Thu, Mar 26, 11:12 AM
This revision is now accepted and ready to land.Thu, Mar 26, 11:12 AM
ardumont edited the summary of this revision. (Show Details)Thu, Mar 26, 11:17 AM
ardumont updated this revision to Diff 10269.Thu, Mar 26, 11:19 AM

Add docstring to test

(Test will fail because swh.model upload to pypi is failing for now)

ardumont retitled this revision from test_storage: Remove no longer relevant validation test to test: Adapt origin validation test according to latest model changes.Thu, Mar 26, 3:41 PM
ardumont updated this revision to Diff 10284.Thu, Mar 26, 3:44 PM

Rebase to latest master