ardumont retitled this revision from (ci: fix master build) swh.journal: tests: Adapt model according to latest change to (ci: fix master build) journal.tests: Adapt model according to latest change.Mar 27 2020, 7:47 AM

olasd accepted this revision.Mar 27 2020, 9:26 AM

This revision is now accepted and ready to land.Mar 27 2020, 9:26 AM

olasd resigned from this revision.Mar 27 2020, 9:27 AM

This revision now requires review to proceed.Mar 27 2020, 9:27 AM

Oops, sorry, I thought of something.

I think we need an origin fixer to drop the potential types in the origin topic instead. @vlorentz, what do you think?

Oops, sorry, I thought of something.

I think we need an origin fixer to drop the potential types in the origin topic instead. @vlorentz, what do you think?

I thought it was already there...
so something is off somewhere indeed.

In D2898#69921, @ardumont wrote:

Oops, sorry, I thought of something.

I think we need an origin fixer to drop the potential types in the origin topic instead. @vlorentz, what do you think?

I thought it was already there...
so something is off somewhere indeed.

It's on origin_visit [1], not origin.
So yeah, probably as you mentioned, we need one.

[1] https://forge.softwareheritage.org/source/swh-journal/browse/master/swh/journal/fixer.py$236-239

ardumont added a child revision: D2901: tests.utils: Test from modules using this need to call close method.Mar 27 2020, 9:55 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 27 2020, 10:11 AM

Closed by commit rDJNL8ce4c0ba673e: tests: Adapt model according to latest change (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDJNL8ce4c0ba673e: tests: Adapt model according to latest change.

oops, i pushed that diff by mistake.
i think arcanist did more than what i asked... (well, what i had anticipated more like).

Still, i'll fix correctly the origin with a fixer in another diff.

ardumont mentioned this in D2903: replayer: Allow legacy origin to be replayed.Mar 27 2020, 10:36 AM