Paths

Table of Contentst

Differential D1487

Update scheduler task names to new ones
ClosedPublic
Actions

Authored by anlambert on May 20 2019, 3:32 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDDEPc1e6ffa164ae: signals: Update scheduler task names to new ones

Summary

Update scheduler task names for deposit to the new naming scheme (see D1440).

Warning: The new task names related to deposit have not been added to the production database. This should be done prior to any deployment.

Related T1508

Diff Detail

Repository

rDDEP Push deposit

Branch

new-task-names

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 5852
Build 8016: tox-on-jenkins	Jenkins
Build 8015: arc lint + arc unit

Event Timeline

anlambert created this revision.May 20 2019, 3:32 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 20 2019, 3:32 PM

anlambert edited the summary of this revision. (Show Details)May 20 2019, 3:33 PM

Build is green
See https://jenkins.softwareheritage.org/job/DDEP/job/tox/154/ for more details.

Harbormaster completed remote builds in B5819: Diff 4885.May 20 2019, 3:39 PM

I've got two questions that @ardumont or @moranegg probably have an opinion about :)

swh/deposit/signals.py
85–86	Do we really need the `-archive` suffix? There's nothing specific to archive-based deposits here.
101–102	Ditto here, do we really need the `-from-archive` suffix?

Indeed, those task names could be shorter.

There may be others to change in the renaming I did in D1440. Considering only the loading related task names have been updated
in production database, the other task names can still be changed.

ardumont added inline comments.May 20 2019, 6:37 PM

swh/deposit/signals.py
85–86	Indeed, plus in the end we do more than just check the deposit's archive, we check(ed?) also for some metadata.
101–102	Nope, we can drop this.

ardumont accepted this revision.May 21 2019, 9:47 AM

ardumont added inline comments.

swh/deposit/signals.py
101–102	To synthesize, call it `load-deposit` and the other one `check-deposit`.

This revision is now accepted and ready to land.May 21 2019, 9:47 AM

Rebase and update task names to shorter ones

Build is green
See https://jenkins.softwareheritage.org/job/DDEP/job/tox/155/ for more details.

Harbormaster completed remote builds in B5852: Diff 4912.May 21 2019, 1:34 PM

Closed by commit rDDEPc1e6ffa164ae: signals: Update scheduler task names to new ones (authored by anlambert). · Explain WhyMay 21 2019, 1:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

deposit/

14 lines

Diff 4912

swh/deposit/signals.py

Loading...