Page MenuHomeSoftware Heritage

Update scheduler task names to new ones
ClosedPublic

Authored by anlambert on May 20 2019, 3:32 PM.

Details

Summary

Update scheduler task names for deposit to the new naming scheme (see D1440).

Warning: The new task names related to deposit have not been added to the production database. This should be done prior to any deployment.

Related T1508

Diff Detail

Repository
rDDEP Push deposit
Branch
new-task-names
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5819
Build 7968: tox-on-jenkinsJenkins
Build 7967: arc lint + arc unit

Event Timeline

I've got two questions that @ardumont or @moranegg probably have an opinion about :)

swh/deposit/signals.py
87

Do we really need the -archive suffix? There's nothing specific to archive-based deposits here.

104

Ditto here, do we really need the -from-archive suffix?

Indeed, those task names could be shorter.

There may be others to change in the renaming I did in D1440. Considering only the loading related task names have been updated
in production database, the other task names can still be changed.

swh/deposit/signals.py
87

Indeed, plus in the end we do more than just check the deposit's archive, we check(ed?) also for some metadata.

104

Nope, we can drop this.

ardumont added inline comments.
swh/deposit/signals.py
104

To synthesize, call it load-deposit and the other one check-deposit.

This revision is now accepted and ready to land.May 21 2019, 9:47 AM

Rebase and update task names to shorter ones

This revision was automatically updated to reflect the committed changes.