Page MenuHomeSoftware Heritage

Update scheduler task names to new ones

Authored by anlambert on May 20 2019, 3:32 PM.



Update scheduler task names for deposit to the new naming scheme (see D1440).

Warning: The new task names related to deposit have not been added to the production database. This should be done prior to any deployment.

Related T1508

Diff Detail

rDDEP swh-deposit
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.May 20 2019, 3:32 PM
anlambert edited the summary of this revision. (Show Details)May 20 2019, 3:33 PM

I've got two questions that @ardumont or @moranegg probably have an opinion about :)


Do we really need the -archive suffix? There's nothing specific to archive-based deposits here.


Ditto here, do we really need the -from-archive suffix?

Indeed, those task names could be shorter.

There may be others to change in the renaming I did in D1440. Considering only the loading related task names have been updated
in production database, the other task names can still be changed.

ardumont added inline comments.May 20 2019, 6:37 PM

Indeed, plus in the end we do more than just check the deposit's archive, we check(ed?) also for some metadata.


Nope, we can drop this.

ardumont accepted this revision.May 21 2019, 9:47 AM
ardumont added inline comments.

To synthesize, call it load-deposit and the other one check-deposit.

This revision is now accepted and ready to land.May 21 2019, 9:47 AM
anlambert updated this revision to Diff 4912.May 21 2019, 1:31 PM

Rebase and update task names to shorter ones

This revision was automatically updated to reflect the committed changes.