Page MenuHomeSoftware Heritage

Refactor swh/scheduler/updater as well
ClosedPublic

Authored by douardda on Jan 29 2019, 3:11 PM.

Details

Summary
  • use the same config system as the main backend, with the same conventions,
  • do not make SchedulerUpdaterBackend inherit from DbBackend, use a simple association, similar to the SchedulerBackend class,
  • refactor the ghtorrent the same (explicit config),
  • same for the updater writer
  • move their main functions in cli.py
  • adapt tests accordingly

Depends on D1027

Diff Detail

Repository
rDSCH Scheduling utilities
Branch
wip
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 3838
Build 5026: tox-on-jenkinsJenkins
Build 5025: arc lint + arc unit

Event Timeline

douardda created this revision.Jan 29 2019, 3:11 PM
ardumont added inline comments.
swh/scheduler/cli.py
662

beware the packaging debian here, iirc, the packages are separated (without dependency i think)...

ardumont accepted this revision.Jan 30 2019, 10:27 AM

Sounds good.

I foresee impacts on the configuration part (swh-site) and the debian packaging.

Not completely sure about the the impacts for the "production" setup (swh-site).
It seems the some configuration changed (key renaming, plus the way it's loaded).

This revision is now accepted and ready to land.Jan 30 2019, 10:27 AM
This revision was automatically updated to reflect the committed changes.