Differential D1028

updater as well
ClosedPublic
Actions

Authored by douardda on Jan 29 2019, 3:11 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSCHf338b75c739e: Refactor swh/scheduler/updater as well

Summary

use the same config system as the main backend, with the same conventions,
do not make SchedulerUpdaterBackend inherit from DbBackend, use a simple association, similar to the SchedulerBackend class,
refactor the ghtorrent the same (explicit config),
same for the updater writer
move their main functions in cli.py
adapt tests accordingly

Depends on D1027

Diff Detail

Repository

rDSCH Scheduling utilities

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 3812
Build 4986: tox-on-jenkins	Jenkins
Build 4985: arc lint + arc unit

Event Timeline

douardda created this revision.Jan 29 2019, 3:11 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 29 2019, 3:11 PM

Harbormaster failed remote builds in B3812: Diff 3258!Jan 29 2019, 3:11 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/123/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/123/console

ardumont added a subscriber: ardumont.Jan 29 2019, 5:46 PM

ardumont added inline comments.

swh/scheduler/cli.py
662	beware the packaging debian here, iirc, the packages are separated (without dependency i think)...

Sounds good.

I foresee impacts on the configuration part (swh-site) and the debian packaging.

Not completely sure about the the impacts for the "production" setup (swh-site).
It seems the some configuration changed (key renaming, plus the way it's loaded).

This revision is now accepted and ready to land.Jan 30 2019, 10:27 AM

rebased

Harbormaster failed remote builds in B3838: Diff 3282!Jan 30 2019, 10:54 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/134/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/134/console

douardda added a child revision: D1034: Kill DbBackend class.Jan 30 2019, 10:59 AM

Closed by commit rDSCHf338b75c739e: Refactor swh/scheduler/updater as well (authored by douardda). · Explain WhyJan 30 2019, 11:54 AM

This revision was automatically updated to reflect the committed changes.