Differential D1025

Add support for content-negotiation in the API
ClosedPublic
Actions

Authored by douardda on Jan 29 2019, 3:01 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDSCHcebc11d1752e: Refactor the scheduler's backend to use swh.core.db.BaseDb (part 2)

Summary

depends on D1024

Diff Detail

Repository

rDSCH Scheduling utilities

Branch

wip

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 3835
Build 5020: tox-on-jenkins	Jenkins
Build 5019: arc lint + arc unit

Event Timeline

douardda created this revision.Jan 29 2019, 3:01 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 29 2019, 3:01 PM

Harbormaster failed remote builds in B3807: Diff 3253!Jan 29 2019, 3:01 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/118/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/118/console

rebased

Harbormaster failed remote builds in B3809: Diff 3255!Jan 29 2019, 3:05 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/120/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/120/console

douardda added a child revision: D1026: Refactor config handling in cli.py.Jan 29 2019, 3:09 PM

vlorentz accepted this revision.Jan 29 2019, 4:52 PM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/scheduler/api/server.py
45–48	Can be rewritten as: def has_no_empty_params(rule): return len(rule.defaults or ()) >= len(rule.arguments or ())
171–183	What is this new endpoint for?

This revision is now accepted and ready to land.Jan 29 2019, 4:52 PM

vlorentz requested changes to this revision.Jan 29 2019, 4:53 PM

vlorentz added inline comments.

swh/scheduler/api/server.py
171–183	And it lacks a test.

This revision now requires changes to proceed.Jan 29 2019, 4:53 PM

Extract the /site-map endpoint in a dedicated diff

sorry part of this diff has been mistakenly push as 94258bda1846

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/131/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/131/console

Harbormaster failed remote builds in B3835: Diff 3279!Jan 30 2019, 10:52 AM

vlorentz accepted this revision.Jan 30 2019, 11:48 AM

This revision is now accepted and ready to land.Jan 30 2019, 11:48 AM

Closed by commit rDSCHcebc11d1752e: Refactor the scheduler's backend to use swh.core.db.BaseDb (part 2) (authored by douardda). · Explain WhyJan 30 2019, 11:54 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

scheduler/

api/

89 lines

Diff 3279

swh/scheduler/api/server.py

Loading...