Page MenuHomeSoftware Heritage

Add support for content-negotiation in the API
ClosedPublic

Authored by douardda on Jan 29 2019, 3:01 PM.

Diff Detail

Repository
rDSCH Scheduling utilities
Branch
master
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 3809
Build 4980: tox-on-jenkinsJenkins
Build 4979: arc lint + arc unit

Event Timeline

douardda created this revision.Jan 29 2019, 3:01 PM
vlorentz accepted this revision.Jan 29 2019, 4:52 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/scheduler/api/server.py
46–49

Can be rewritten as:

def has_no_empty_params(rule):
    return len(rule.defaults or ()) >= len(rule.arguments or ())
179–191

What is this new endpoint for?

This revision is now accepted and ready to land.Jan 29 2019, 4:52 PM
vlorentz requested changes to this revision.Jan 29 2019, 4:53 PM
vlorentz added inline comments.
swh/scheduler/api/server.py
179–191

And it lacks a test.

This revision now requires changes to proceed.Jan 29 2019, 4:53 PM
douardda updated this revision to Diff 3279.Jan 30 2019, 10:49 AM
douardda marked 3 inline comments as done.

Extract the /site-map endpoint in a dedicated diff

sorry part of this diff has been mistakenly push as 94258bda1846

vlorentz accepted this revision.Jan 30 2019, 11:48 AM
This revision is now accepted and ready to land.Jan 30 2019, 11:48 AM
This revision was automatically updated to reflect the committed changes.