Page MenuHomeSoftware Heritage

scanner-benchmark: add algorithms timings in results
ClosedPublic

Authored by DanSeraf on Thu, Apr 29, 2:38 PM.

Details

Summary
  • reflect swh-model changes
  • make mypy pass

Diff Detail

Repository
rDTSCN Code scanner
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Apr 29, 2:38 PM
Harbormaster failed remote builds in B21136: Diff 20146!
zack added a subscriber: zack.

the fact that algo_min is treated differently than other cases is horrible :-P, but it's not new in this diff, so ok :)
also, in the requirements you should probably put what's the minimum version of swh.core that you need, but that too is not a big deal

so i'm accepting this, correct what you can before merging (into the branch), but nothing is blocking

This revision is now accepted and ready to land.Thu, Apr 29, 3:01 PM
  • minimum required version for swh-model
  • treat algo_min in the same way as other cases
This revision was landed with ongoing or failed builds.Thu, Apr 29, 3:20 PM
This revision was automatically updated to reflect the committed changes.