scanner: access MerkleNodeInfo with the correct key
ClosedPublic
Actions

Authored by DanSeraf on Jul 8 2021, 4:35 PM.

Details

Reviewers

zack

Group Reviewers

Reviewers

Commits

rDTSCN33b1316bcdab: access MerkleNodeInfo with the correct key

Summary

The key must be swh.model.identifiers.CoreSWHID not str.

Diff Detail

Repository

rDTSCN Code scanner

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

DanSeraf created this revision.Jul 8 2021, 4:35 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 8 2021, 4:35 PM

Build is green

Patch application report for D5981 (id=21561)

Rebasing onto 0d92c754c8...

Current branch diff-target is up to date.

Changes applied before test

commit 33b1316bcdab64c537e0f3fc40c320edec40c285
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Thu Jul 8 16:32:08 2021 +0200

    access MerkleNodeInfo with the correct key

See https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/135/ for more details.

Harbormaster completed remote builds in B22535: Diff 21561.Jul 8 2021, 4:38 PM

DanSeraf requested review of this revision.Jul 8 2021, 4:38 PM

zack accepted this revision.Jul 8 2021, 5:29 PM

This revision is now accepted and ready to land.Jul 8 2021, 5:29 PM

Closed by commit rDTSCN33b1316bcdab: access MerkleNodeInfo with the correct key (authored by DanSeraf). · Explain WhyJul 8 2021, 6:34 PM

This revision was automatically updated to reflect the committed changes.

DanSeraf added a commit: rDTSCN33b1316bcdab: access MerkleNodeInfo with the correct key.

Revision Contents
Changeset List

Path

Size

swh/

scanner/

output.py

2 lines

Diff 21562

View Options

scanner: access MerkleNodeInfo with the correct keyClosedPublicActions