Fix src/dst inversion, add regression test

Fixed in rDDOC55cdfd9ee957f57cf91b0f6932cc941d2887d933

Copying my comment from a linked diff:

Hey! Thanks for this initial diff.

Done

LGTM too

Super clunky, a lot of message types aren't handled, some messages get filtered out. I don't recall all the specifics but I tried it around a year ago and it was really bad.

LGTM

It looks to me like this would be simpler if max_edges was given as a parameter to Traversal, since it's common to most methods. Would that work?

rebase

Add documentation and licensing info

Thanks for the review!

I just want to write something here that maybe isn't clear from the initial task description. This filtering must happen *after* the visit, not during. We can already change *how* the graph is visited using the edges parameter, the goal of this task is to filter the result post-visit.

Right, I suppose we can close the task then?

Remove debug print

Rebase

@zack We talked about this on IRC with @vlorentz, I think this issue is invalid. We chose to have the source and destination nodes as part of the URI in the API. Semantically, it makes sense that accessing the path without these path fragments would return a 404: it's not a missing argument but an invalid path. If we had a ?src= and a &dst= arguments instead, then having a 400 error would make sense, but in our case the semantics are really weird.

• Fix reviews
• Add backward compatibility for loading MPH on strings

Duplicate of T2431