It made too many assumptions on how swh-graph orders edges,
and would break on implementation changes.
Motivation: I am working on an alternative implementation.
Details
Details
- Reviewers
seirl - Group Reviewers
Reviewers - Commits
- rDGRPH1a8b00f4cdc4: Make test_visit_edges_limited less strict
Diff Detail
Diff Detail
- Repository
- rDGRPH Compressed graph representation
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D5664 (id=20232)
Rebasing onto 6f21897a7e...
Current branch diff-target is up to date.
Changes applied before test
commit ba03f35ae34a88eaa1eab18500f4a3f60dddc643
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon May 3 18:10:33 2021 +0200
Make test_visit_edges_limited less strict
It made too many assumptions on how swh-graph orders edges,
and would break on implementation changes.
Motivation: I am working on an alternative implementation.See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/102/ for more details.
| swh/graph/tests/test_api_client.py | ||
|---|---|---|
| 132–135 | Maybe a comment would help here, just to explain that there are two semantically valid answers and that this checks we're getting one of the two. It took me a while to get what you were doing. | |
Comment Actions
Build is green
Patch application report for D5664 (id=20238)
Rebasing onto 6f21897a7e...
Current branch diff-target is up to date.
Changes applied before test
commit 1a8b00f4cdc4bbabc37adc4dd91c43c66ca74cf7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon May 3 18:10:33 2021 +0200
Make test_visit_edges_limited less strict
It made too many assumptions on how swh-graph orders edges,
and would break on implementation changes.
Motivation: I am working on an alternative implementation.See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/104/ for more details.