Page MenuHomeSoftware Heritage
Feed All Stories

Jul 4 2022

swh-public-ci added a comment to D8077: Add a static query cost calculator to reject malicious quries.

Build is green

Jul 4 2022, 5:02 PM
jayeshv updated the diff for D8077: Add a static query cost calculator to reject malicious quries.

Remove multiplier for connections; set complexity to 2

Jul 4 2022, 5:00 PM
ardumont updated the task description for T4334: Test rollback of a repo migration .
Jul 4 2022, 4:01 PM · System administration, GitLab migration, Roadmap 2020
ardumont reopened T4334: Test rollback of a repo migration , a subtask of T4064: Test GitLab migration scripts, as Open.
Jul 4 2022, 4:00 PM · System administration, GitLab migration, Roadmap 2020
ardumont reopened T4334: Test rollback of a repo migration as "Open".
Jul 4 2022, 4:00 PM · System administration, GitLab migration, Roadmap 2020
swh-public-ci added a comment to D8077: Add a static query cost calculator to reject malicious quries.

Build is green

Jul 4 2022, 3:59 PM
jayeshv updated the diff for D8077: Add a static query cost calculator to reject malicious quries.

cost for nodes

Jul 4 2022, 3:57 PM
jayeshv requested review of D8077: Add a static query cost calculator to reject malicious quries.
Jul 4 2022, 3:36 PM
jayeshv added a revision to T4299: GraphQL: Static query validation and max cost limiting: D8077: Add a static query cost calculator to reject malicious quries.
Jul 4 2022, 3:34 PM · GraphQL API
vlorentz requested review of D8076: Make __iter__ actually return composite objids.
Jul 4 2022, 3:13 PM
vlorentz requested review of D8075: Remove unused fallbacks for old msgpack version.
Jul 4 2022, 3:06 PM
vlorentz requested review of D8074: Remove ID-based filters.
Jul 4 2022, 3:00 PM
Harbormaster failed to build B30236: rDCIDX79499ea59658: metadata_dictionary: Add mappings for composer.json for rDCIDX79499ea59658: metadata_dictionary: Add mappings for composer.json!
Jul 4 2022, 2:52 PM
VickyMerzOwn closed T4357: Metadata Indexer for Composer as Resolved.
Jul 4 2022, 2:49 PM · Indexer
VickyMerzOwn closed D8047: Indexer for Packagist(composer.json).
Jul 4 2022, 2:46 PM
VickyMerzOwn committed rDCIDX79499ea59658: metadata_dictionary: Add mappings for composer.json (authored by VickyMerzOwn).
metadata_dictionary: Add mappings for composer.json
Jul 4 2022, 2:46 PM
Harbormaster failed remote builds in B30235: Diff 29143 for D8047: Indexer for Packagist(composer.json)!
Jul 4 2022, 2:30 PM
swh-public-ci added a comment to D8047: Indexer for Packagist(composer.json).

Build was aborted

Jul 4 2022, 2:30 PM
vlorentz accepted D8047: Indexer for Packagist(composer.json).
Jul 4 2022, 2:28 PM
VickyMerzOwn updated the diff for D8047: Indexer for Packagist(composer.json).

Fix failed build: Corrects test in test_composer

Jul 4 2022, 2:19 PM
Harbormaster failed remote builds in B30234: Diff 29142 for D8047: Indexer for Packagist(composer.json)!
Jul 4 2022, 2:14 PM
swh-public-ci added a comment to D8047: Indexer for Packagist(composer.json).

Build has FAILED

Jul 4 2022, 2:14 PM
vlorentz requested review of D8073: Use compact URIs for ForgeFed and ActivityStreams.
Jul 4 2022, 2:10 PM
vlorentz requested review of D8072: Use separate base classes for intrinsic and extrinsic mappings.
Jul 4 2022, 2:10 PM
VickyMerzOwn updated the diff for D8047: Indexer for Packagist(composer.json).

Rebasing

Jul 4 2022, 2:08 PM
vlorentz closed D8029: Start introducing composite ObjId in the interface.
Jul 4 2022, 2:07 PM
vlorentz committed rDOBJS667cb87b9367: Start introducing composite ObjId in the interface (authored by vlorentz).
Start introducing composite ObjId in the interface
Jul 4 2022, 2:07 PM
vlorentz requested review of D8070: cff: Remove redundant @context setting.
Jul 4 2022, 1:09 PM
vlorentz committed rDMOD4073b824ddda: hashutil: Add type annotations to conversion functions (authored by vlorentz).
hashutil: Add type annotations to conversion functions
Jul 4 2022, 12:58 PM
vlorentz closed D8058: Add support for origin_extrinsic_metadata to the storage.
Jul 4 2022, 12:47 PM
vlorentz closed D8060: Add extrinsic metadata indexer.
Jul 4 2022, 12:47 PM
vlorentz committed rDCIDXf26b4c8b1ca7: Add support for origin_extrinsic_metadata to the storage (authored by vlorentz).
Add support for origin_extrinsic_metadata to the storage
Jul 4 2022, 12:47 PM
vlorentz committed rDCIDX61b22345e70b: Add extrinsic metadata indexer (authored by vlorentz).
Add extrinsic metadata indexer
Jul 4 2022, 12:47 PM
vlorentz committed rDCIDXdb02285bee9b: reorder SQL functions (authored by vlorentz).
reorder SQL functions
Jul 4 2022, 12:47 PM
vlorentz closed D8054: github mapping: Add support for terms outside the codemeta context.
Jul 4 2022, 12:47 PM
vlorentz closed D8055: github mapping: Add support for more terms from the Codemeta crosswalk.
Jul 4 2022, 12:47 PM
vlorentz committed rDCIDX151a3b8a2b69: github mapping: Add support for more terms from the Codemeta crosswalk (authored by vlorentz).
github mapping: Add support for more terms from the Codemeta crosswalk
Jul 4 2022, 12:47 PM
vlorentz committed rDCIDX8948c8397251: github mapping: Add support for terms outside the codemeta context (authored by vlorentz).
github mapping: Add support for terms outside the codemeta context
Jul 4 2022, 12:47 PM
vlorentz closed D8053: Add minimal GitHub metadata mapping.
Jul 4 2022, 12:47 PM
vlorentz committed rDCIDX9085cae01009: Add minimal GitHub metadata mapping (authored by vlorentz).
Add minimal GitHub metadata mapping
Jul 4 2022, 12:47 PM
swh-public-ci added a comment to D8060: Add extrinsic metadata indexer.

Build is green

Jul 4 2022, 12:45 PM
swh-public-ci added a comment to D8058: Add support for origin_extrinsic_metadata to the storage.

Build is green

Jul 4 2022, 12:45 PM
swh-public-ci added a comment to D8055: github mapping: Add support for more terms from the Codemeta crosswalk.

Build is green

Jul 4 2022, 12:45 PM
swh-public-ci added a comment to D8054: github mapping: Add support for terms outside the codemeta context.

Build is green

Jul 4 2022, 12:45 PM
swh-public-ci added a comment to D8053: Add minimal GitHub metadata mapping.

Build is green

Jul 4 2022, 12:44 PM
vlorentz updated the diff for D8060: Add extrinsic metadata indexer.

rebase

Jul 4 2022, 12:38 PM
vlorentz updated the diff for D8058: Add support for origin_extrinsic_metadata to the storage.

rebase + add migration

Jul 4 2022, 12:38 PM
vlorentz updated the diff for D8055: github mapping: Add support for more terms from the Codemeta crosswalk.

rebase

Jul 4 2022, 12:38 PM
vlorentz updated the diff for D8054: github mapping: Add support for terms outside the codemeta context.

rebase + rename decorator

Jul 4 2022, 12:38 PM
vlorentz updated the diff for D8053: Add minimal GitHub metadata mapping.

rebase

Jul 4 2022, 12:38 PM
olasd removed a watcher for Staff: olasd.
Jul 4 2022, 12:33 PM
Harbormaster failed remote builds in B30209: Diff 29118 for D8048: Move mapping-specific tests to a new directory!
Jul 4 2022, 12:33 PM
swh-public-ci added a comment to D8048: Move mapping-specific tests to a new directory.

Build was aborted

Jul 4 2022, 12:33 PM
olasd added a member for Staff: sgranger.
Jul 4 2022, 12:32 PM
Harbormaster failed remote builds in B30208: Diff 29117 for D8046: Remove SingleFileMapping from JsonMapping's base classes!
Jul 4 2022, 12:32 PM
swh-public-ci added a comment to D8046: Remove SingleFileMapping from JsonMapping's base classes.

Build was aborted

Jul 4 2022, 12:32 PM
douardda added inline comments to D8053: Add minimal GitHub metadata mapping.
Jul 4 2022, 12:29 PM
vlorentz closed D8048: Move mapping-specific tests to a new directory.
Jul 4 2022, 12:29 PM
vlorentz committed rDCIDX3074268b1b7d: Move mapping-specific tests to a new directory (authored by vlorentz).
Move mapping-specific tests to a new directory
Jul 4 2022, 12:29 PM
vlorentz closed D8046: Remove SingleFileMapping from JsonMapping's base classes.
Jul 4 2022, 12:29 PM
vlorentz committed rDCIDXf4d1ce835ca3: Remove given/when/then comments (authored by vlorentz).
Remove given/when/then comments
Jul 4 2022, 12:29 PM
vlorentz committed rDCIDXe6b03db91c99: Remove SingleFileMapping from JsonMapping's base classes (authored by vlorentz).
Remove SingleFileMapping from JsonMapping's base classes
Jul 4 2022, 12:29 PM
vlorentz closed D8045: Add typing to detect_metadata() and related functions.
Jul 4 2022, 12:29 PM
vlorentz committed rDCIDX8c5a84459d44: Add typing to detect_metadata() and related functions (authored by vlorentz).
Add typing to detect_metadata() and related functions
Jul 4 2022, 12:29 PM
swh-public-ci added a comment to D8045: Add typing to detect_metadata() and related functions.

Build is green

Jul 4 2022, 12:27 PM
douardda accepted D8060: Add extrinsic metadata indexer.
Jul 4 2022, 12:26 PM
vlorentz updated the diff for D8048: Move mapping-specific tests to a new directory.

rebase

Jul 4 2022, 12:21 PM
vlorentz updated the diff for D8046: Remove SingleFileMapping from JsonMapping's base classes.

rebase

Jul 4 2022, 12:21 PM
douardda accepted D8058: Add support for origin_extrinsic_metadata to the storage.

Shouldn't there be a migration script as well?

Jul 4 2022, 12:21 PM
vlorentz updated the diff for D8045: Add typing to detect_metadata() and related functions.

update docstring

Jul 4 2022, 12:21 PM
vlorentz added inline comments to D8053: Add minimal GitHub metadata mapping.
Jul 4 2022, 12:16 PM
swh-public-ci added a comment to D8048: Move mapping-specific tests to a new directory.

Build is green

Jul 4 2022, 12:13 PM
swh-public-ci added a comment to D8046: Remove SingleFileMapping from JsonMapping's base classes.

Build is green

Jul 4 2022, 12:13 PM
swh-public-ci added a comment to D8045: Add typing to detect_metadata() and related functions.

Build is green

Jul 4 2022, 12:13 PM
vlorentz added inline comments to D8053: Add minimal GitHub metadata mapping.
Jul 4 2022, 12:12 PM
douardda accepted D8055: github mapping: Add support for more terms from the Codemeta crosswalk.
Jul 4 2022, 12:11 PM
douardda added inline comments to D8045: Add typing to detect_metadata() and related functions.
Jul 4 2022, 12:09 PM
vlorentz updated the diff for D8048: Move mapping-specific tests to a new directory.

rebase

Jul 4 2022, 12:07 PM
vlorentz updated the diff for D8046: Remove SingleFileMapping from JsonMapping's base classes.

rebase

Jul 4 2022, 12:07 PM
vlorentz updated the diff for D8045: Add typing to detect_metadata() and related functions.

update docstring and make commit msg more descriptive

Jul 4 2022, 12:07 PM
douardda accepted D8054: github mapping: Add support for terms outside the codemeta context.

ok but the wording of the mark_production decorator

Jul 4 2022, 12:06 PM
vlorentz added inline comments to D8045: Add typing to detect_metadata() and related functions.
Jul 4 2022, 12:03 PM
vlorentz added a comment to D8045: Add typing to detect_metadata() and related functions.
In D8045#209752, @olasd wrote:

AFAICT this function now does the detection itself, so maybe it deserves an update.

Jul 4 2022, 12:01 PM
douardda accepted D8053: Add minimal GitHub metadata mapping.

I'm not against this, but I have my doubts on the overall "architecture".

Jul 4 2022, 11:59 AM
olasd accepted D8045: Add typing to detect_metadata() and related functions.

I'm slightly surprised by the change of signature for translate_directory_intrinsic_metadata without change to the docstring. AFAICT this function now does the detection itself, so maybe it deserves an update.

Jul 4 2022, 11:49 AM
vlorentz added a comment to D8048: Move mapping-specific tests to a new directory.

If this only test being moved or are there other (eg new tests) coming along? If so, please specify it in the commit message.

Jul 4 2022, 11:48 AM
douardda accepted D8048: Move mapping-specific tests to a new directory.

Don't like the zz-celery hack, but well, that's life. Did not check the new test files actually correspond to old test_metadata.py content. If this only test being moved or are there other (eg new tests) coming along? If so, please specify it in the commit message.

Jul 4 2022, 11:47 AM
ardumont added a comment to D8066: Add the 'flavor' argument to db_utils.initialize_database_for_module().

lgtm but it's missing the test case around it. It should not be too hard to add a

scenario which lifts the flavor parameter, shouldn't it? possibly, but I had it tested
from swh-storage (D8067)

Jul 4 2022, 11:43 AM
douardda added inline comments to D8045: Add typing to detect_metadata() and related functions.
Jul 4 2022, 11:42 AM
swh-public-ci added a comment to D8029: Start introducing composite ObjId in the interface.

Build is green

Jul 4 2022, 11:42 AM
vlorentz updated the diff for D8029: Start introducing composite ObjId in the interface.

seaweed: replace with objid_to_default_hex

Jul 4 2022, 11:39 AM
rdicosmo added a comment to T3756: Create a browser extension / bookmarklet for archival status.

Ongoing on https://github.com/rdicosmo/updateswh, landing page is on https://www.softwareheritage.org/browser-extensions/

Jul 4 2022, 11:08 AM
douardda added a comment to D8066: Add the 'flavor' argument to db_utils.initialize_database_for_module().

lgtm but it's missing the test case around it. It should not be too hard to add a scenario which lifts the flavor parameter, shouldn't it?

Jul 4 2022, 11:00 AM
ardumont added a comment to T4135: staging: Deploy graphql service.

Heads up, current work to improve the jenkins tooling has been tested (docker-compose,
jenkins in docker, triggering pipeline with docker).

Jul 4 2022, 10:50 AM · System administration, GraphQL API
ardumont added a project to T4371: Deploy swh-scrubber on all storage instances: System administration.
Jul 4 2022, 10:47 AM · System administration, Archive integrity, Storage manager
ardumont added projects to T4371: Deploy swh-scrubber on all storage instances: Storage manager, Archive integrity.
Jul 4 2022, 10:47 AM · System administration, Archive integrity, Storage manager
ardumont updated the task description for T4371: Deploy swh-scrubber on all storage instances.
Jul 4 2022, 10:25 AM · System administration, Archive integrity, Storage manager
ardumont triaged T4371: Deploy swh-scrubber on all storage instances as Normal priority.
Jul 4 2022, 10:24 AM · System administration, Archive integrity, Storage manager
ardumont added a comment to D8066: Add the 'flavor' argument to db_utils.initialize_database_for_module().

lgtm but it's missing the test case around it. It should not be too hard to add a scenario which lifts the flavor parameter, shouldn't it?

Jul 4 2022, 9:55 AM
jayeshv updated the task description for T4299: GraphQL: Static query validation and max cost limiting.
Jul 4 2022, 9:40 AM · GraphQL API