To conform to the existing signature
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T4403: Update objstorage interface to return dicts of hashes instead of single sha1
- Commits
- rDOBJS2e642be3ec0d: Make __iter__ actually return composite objids
Diff Detail
Diff Detail
- Repository
- rDOBJS Object storage
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D8076 (id=29148)
Could not rebase; Attempt merge onto 667cb87b93...
Updating 667cb87..2e642be Fast-forward swh/objstorage/api/client.py | 10 +- swh/objstorage/backends/azure.py | 5 +- swh/objstorage/backends/http.py | 3 +- swh/objstorage/backends/in_memory.py | 7 +- swh/objstorage/backends/libcloud.py | 10 +- swh/objstorage/backends/pathslicing.py | 21 +- swh/objstorage/backends/seaweedfs/objstorage.py | 12 +- swh/objstorage/multiplexer/filter/__init__.py | 13 +- swh/objstorage/multiplexer/filter/id_filter.py | 81 ------ swh/objstorage/tests/objstorage_testing.py | 12 +- swh/objstorage/tests/test_multiplexer_filter.py | 313 --------------------- .../tests/test_objstorage_pathslicing.py | 8 +- swh/objstorage/tests/test_readonly_filter.py | 85 ++++++ 13 files changed, 140 insertions(+), 440 deletions(-) delete mode 100644 swh/objstorage/multiplexer/filter/id_filter.py delete mode 100644 swh/objstorage/tests/test_multiplexer_filter.py create mode 100644 swh/objstorage/tests/test_readonly_filter.py
Changes applied before test
commit 2e642be3ec0d33e172fba7e55be99fa5ced327c2
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Jul 4 15:10:35 2022 +0200
Make __iter__ actually return composite objids
To conform to the existing signature
commit de6be10bf10d021a08e6da0aaca4aa2fd1483068
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Jul 4 14:57:30 2022 +0200
Remove ID-based filters
They are not used anywhereSee https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/171/ for more details.
| swh/objstorage/backends/libcloud.py | ||
|---|---|---|
| 1 | don't we use this to maintain the S3 mirror? | |
| swh/objstorage/backends/libcloud.py | ||
|---|---|---|
| 1 | good point, no idea then. | |