In D265#5625, @ardumont wrote:

• Refactor tests: use actual prepare_metadata without mocking it for tests

Well, you did not mock, you overrode :)

• Refactor tests: use actual prepare_metadata without mocking it for tests

• Refactor tests: use actual prepare_metadata without mocking it for tests

• Align prepare_metadata and send_tool with Storage capacity to return id for existing tool

• Change metadata provider and tool as additional config
• Added tests for metadata injection
• Refactor origin_metadata injection with prepare_metadata from loader-core

• Refactor for provider_id and tool_id resolution at loader level

After some thoughts this weekend.
I agree that it is more logic to have a send_provider and a send_tool at the loader level if the tool or provider are not in storage.

The question remains, is it the storage job or the other packages job to know that a certain provider has a certain id.
your solution [solA]- sending tool and provider as part of the prepare method is a good idea but
the resolution is made by the loader and not by the storage so it keeps the resolution in the loader's scope.

• Refactor adding origin_metadata to the loaders

• Added tests for metadata injection

Sorry about the mix-up, here it is again..

• Change metadata provider and tool as additional config

• Change metadata provider and tool as additional config

In D266#5422, @olasd wrote:

I think metadata should be added after the data has been fetched (maybe in store_data()?), as it might not be available before.

ack but I'm keeping it in store_metadata()

The critical part of loading metadata is the storage calls, so that's really what should be implemented here, as send_origin_metadata / send_origin_visit_metadata functions that call the underlying storage methods.

Excellent remark
now store_metadata() is in the generic load and implemented in the sub class calling for send_origin_metadata() which is doing the actual exchanges with storage.

• Refactor adding origin_metadata to the loaders

• Refactor entry points to origin_metadata table with get_by function