Page MenuHomeSoftware Heritage
Feed Advanced Search

Aug 16 2022

olasd committed rDPROVd935abf431df: Rename origin.proceed_origin to origin.process_origin (authored by olasd).
Rename origin.proceed_origin to origin.process_origin
Aug 16 2022, 12:35 PM
olasd committed rDPROV08de80b680bd: origin layer: retrieve multiple levels of revision history at once (authored by olasd).
origin layer: retrieve multiple levels of revision history at once
Aug 16 2022, 12:35 PM
olasd committed rDPROV68e1907e7f37: Appease pyright by ensuring target_type is bound (authored by olasd).
Appease pyright by ensuring target_type is bound
Aug 16 2022, 12:35 PM
olasd committed rDPROVedf00f88894f: Use proper signatures in journal_client (authored by olasd).
Use proper signatures in journal_client
Aug 16 2022, 12:35 PM
olasd committed rDPROV8d323c322df2: journal client: only use the provenance context manager once (authored by olasd).
journal client: only use the provenance context manager once
Aug 16 2022, 12:35 PM
olasd committed rDPROV2ac46f58346f: multiplexer: add endpoint counts per backend (authored by olasd).
multiplexer: add endpoint counts per backend
Aug 16 2022, 12:35 PM
olasd committed rDPROV4b3de6177b4f: revision: only trigger partial flushes when necessary (authored by olasd).
revision: only trigger partial flushes when necessary
Aug 16 2022, 12:35 PM
olasd committed rDPROVf5f8555f8e3d: provenance: lower the cache thresholds (authored by olasd).
provenance: lower the cache thresholds
Aug 16 2022, 12:35 PM
olasd committed rDPROV9c936c39779c: revision: sort batches by date, improve logging, add incremental flushing (authored by olasd).
revision: sort batches by date, improve logging, add incremental flushing
Aug 16 2022, 12:35 PM
olasd committed rDPROV5b66b98e62c5: revision: capture datetime exceptions with sentry (authored by olasd).
revision: capture datetime exceptions with sentry
Aug 16 2022, 12:35 PM
olasd committed rDPROVaf09058f0a80: revision: don't process revisions before the epoch (authored by olasd).
revision: don't process revisions before the epoch
Aug 16 2022, 12:35 PM
olasd committed rDPROV3473d4af62d8: revision: don't process revisions with unknown dates (authored by olasd).
revision: don't process revisions with unknown dates
Aug 16 2022, 12:35 PM
olasd committed rDPROV34a9a1ac220b: Remove sneaky caches in the postgresql archive implementation (authored by olasd).
Remove sneaky caches in the postgresql archive implementation
Aug 16 2022, 12:35 PM
olasd committed rDPROVd7d0c3d87605: postgresql archive: add support for partially copied databases (authored by olasd).
postgresql archive: add support for partially copied databases
Aug 16 2022, 12:35 PM
olasd committed rDPROV95eb9622a00c: postgresql archive: don't use custom types (authored by olasd).
postgresql archive: don't use custom types
Aug 16 2022, 12:35 PM
olasd committed rDPROVef7cd991712e: Improve logging in the API client and the revision layer (authored by olasd).
Improve logging in the API client and the revision layer
Aug 16 2022, 12:35 PM
olasd committed rDPROV1efc40c7917f: rabbitmq: close the consumer only after all acks are received (authored by olasd).
rabbitmq: close the consumer only after all acks are received
Aug 16 2022, 12:35 PM
olasd committed rDPROVbae8f4afda45: rabbitmq: Extend timeouts for reception of acks (authored by olasd).
rabbitmq: Extend timeouts for reception of acks
Aug 16 2022, 12:35 PM
olasd committed rDPROV3edf3690258b: Add systemd notification support (authored by olasd).
Add systemd notification support
Aug 16 2022, 12:35 PM
olasd committed rDPROV5cadb13de9eb: Try to avoid some circular imports (authored by olasd).
Try to avoid some circular imports
Aug 16 2022, 12:35 PM
olasd closed D8243: All the current swh.provenance changes that are running in production....
Aug 16 2022, 12:35 PM
olasd committed rDPROV98254d2e930f: blacken swhgraph/archive.py (authored by olasd).
blacken swhgraph/archive.py
Aug 16 2022, 12:35 PM
olasd closed T4439: ns0.euwest.azure stops responding for internal.admin.swh.network when pergamon is unreachable as Resolved.
Aug 16 2022, 12:17 PM · System administration
olasd triaged T4439: ns0.euwest.azure stops responding for internal.admin.swh.network when pergamon is unreachable as Normal priority.
Aug 16 2022, 12:17 PM · System administration
olasd added a comment to D8236: cassandra: Refactor the former installation scripts.

I'm really not a fan of erb templates for yaml configuration files (specifically, seed_provider: <%= @config["seed_provider"].to_yaml().delete_prefix("---") %> is pretty jarring). I agree that inlining the full default config was not a good idea, though.

Aug 16 2022, 11:46 AM
olasd accepted D8223: Convert psycopg2 errors to TransientRemoteException instead of RemoteException.

Looks good, thanks.

Aug 16 2022, 11:17 AM
olasd accepted D8221: Make the RPC client raise a specific exception class on 503.

LGTM, thanks!

Aug 16 2022, 11:13 AM

Aug 12 2022

olasd requested review of D8243: All the current swh.provenance changes that are running in production....
Aug 12 2022, 6:00 PM
olasd accepted D8241: Makefile.sphinx: Exclude root conftest.py from apidoc.
Aug 12 2022, 2:30 PM

Aug 11 2022

olasd placed T4431: Error from swh-search server was not logged/reported by the client up for grabs.
Aug 11 2022, 1:43 PM · System administration, Archive search
olasd closed T4431: Error from swh-search server was not logged/reported by the client as Invalid.
Aug 11 2022, 1:41 PM · System administration, Archive search
olasd accepted D8234: docker: Mount and clone local swh-jenkins-jobs repo for conf testing.

Looks much better indeed!

Aug 11 2022, 1:40 PM
olasd accepted D8233: jobs/swh-pypi-groovy: Use Sentry auth token when building web assets.

Is there a way to use a "service" token rather than one tied to an individual account?

Aug 11 2022, 1:39 PM

Aug 9 2022

olasd committed rSPSITEc3705899fcd2: Fix ceph-mgr prometheus scrape target to use internal fqdn (authored by olasd).
Fix ceph-mgr prometheus scrape target to use internal fqdn
Aug 9 2022, 12:16 PM
olasd committed rSPSITE2cc4f6d47634: Hedgedoc doesn't need a local database server anymore (authored by olasd).
Hedgedoc doesn't need a local database server anymore
Aug 9 2022, 12:09 PM
olasd committed rSPSITE20c9058e28a4: thanos: scrape metrics from all components with prometheus (authored by olasd).
thanos: scrape metrics from all components with prometheus
Aug 9 2022, 11:38 AM

Aug 8 2022

olasd accepted D8209: docker: update the list of created topics.

Shouldn't we add privileged topics too?

Aug 8 2022, 12:27 PM

Aug 5 2022

olasd accepted D8204: Use logger instance instead of logging module directly.
Aug 5 2022, 4:40 PM
olasd published D8204: Use logger instance instead of logging module directly for review.
Aug 5 2022, 4:40 PM
olasd accepted D8203: RPC server: Do not log exceptions with 4xx HTTP status codes.

This could probably be logger.exception instead of an unqualified logging.exception

Aug 5 2022, 4:34 PM

Aug 4 2022

olasd added a comment to T4421: Prioritize archival from gitlab.com.

Looks like there's many more repos that should be visitable but aren't:

Aug 4 2022, 4:51 PM · Archive coverage, Origin-GitLab
olasd accepted D8181: scrubber: Make service parametric on the db instance to scrub.

Great, thanks

Aug 4 2022, 2:46 PM
olasd added a comment to T4421: Prioritize archival from gitlab.com.

updated query running:

Aug 4 2022, 2:29 PM · Archive coverage, Origin-GitLab
olasd added a comment to T4421: Prioritize archival from gitlab.com.

As usual, I'm uneasy with the (general) idea of manually handling some repositories to resorb one bit of lag. This will only increase lag in another area that we will want to cover next. Rinse, repeat.

Aug 4 2022, 2:18 PM · Archive coverage, Origin-GitLab
olasd added inline comments to D8181: scrubber: Make service parametric on the db instance to scrub.
Aug 4 2022, 12:51 PM

Aug 3 2022

olasd committed rSPSITE2df1e7d96b2a: prometheus: don't override scrape configs at all if not needed (authored by olasd).
prometheus: don't override scrape configs at all if not needed
Aug 3 2022, 11:52 AM

Aug 2 2022

olasd accepted D8172: Deactivate non-effective swap configuration on indexer worker.
Aug 2 2022, 12:08 PM
olasd accepted D8170: Add waagent profile to azure worker role.

Not sure I understand the insistence on using variables, but *shrug*

Aug 2 2022, 10:53 AM
olasd added a comment to D8170: Add waagent profile to azure worker role.

I would suggest only matching on line beginnings, so that we can update the values and possibly disable swap if we find it problematic.
I've added escaping of the regexps.

Aug 2 2022, 10:19 AM

Aug 1 2022

olasd added a comment to D8170: Add waagent profile to azure worker role.

Let's use file_line resources instead of using a template which will be out of date 28 seconds after the change is pushed.

Aug 1 2022, 6:16 PM
olasd accepted D8167: Decrease parallelism on indexer workers running journal clients.

The origin extrinsic metadata indexer only runs on a single file at a time, so I don't think it needs to run alone on dedicated hosts.

Aug 1 2022, 3:35 PM

Jul 22 2022

olasd added a comment to T4408: Resume provenance content-revision layer processing through the revision journal client.

FWIW I've also started the provenance storage server as a systemd system service now.

Jul 22 2022, 4:42 PM · Provenance database
olasd closed T4408: Resume provenance content-revision layer processing through the revision journal client as Resolved.
Jul 22 2022, 4:16 PM · Provenance database
olasd added a comment to T4408: Resume provenance content-revision layer processing through the revision journal client.

I've granted mmca access to the production journal for user swh-provenance-mmca.

Jul 22 2022, 4:16 PM · Provenance database
olasd updated the task description for T4408: Resume provenance content-revision layer processing through the revision journal client.
Jul 22 2022, 4:10 PM · Provenance database
olasd committed R259:9c96609c0ef0: Refresh swh.provenance dependencies (authored by olasd).
Refresh swh.provenance dependencies
Jul 22 2022, 12:31 PM
olasd added a comment to T4408: Resume provenance content-revision layer processing through the revision journal client.

I've added an autossh-mmca.service unit on belvedere to have a reverse tunnel from localhost@mmca:5345 -> localhost@belvedere:5432.

Jul 22 2022, 11:43 AM · Provenance database
olasd updated the task description for T4408: Resume provenance content-revision layer processing through the revision journal client.
Jul 22 2022, 11:42 AM · Provenance database
olasd triaged T4408: Resume provenance content-revision layer processing through the revision journal client as High priority.
Jul 22 2022, 11:17 AM · Provenance database
olasd added a comment to T4407: Logo in the annex is truncated.

Looks fine to me, but the SVG wants the font (Alegrya Sans SC) to be installed on your system. We might want to force that to be splines instead of text.

Jul 22 2022, 11:10 AM

Jul 13 2022

olasd committed rSPSITE735877b4c051: thanos on mmca is behind a separate vhost (authored by olasd).
thanos on mmca is behind a separate vhost
Jul 13 2022, 6:18 PM
olasd committed rSPSITE2bb41358d4cc: The thanos query host doesn't need backups (authored by olasd).
The thanos query host doesn't need backups
Jul 13 2022, 6:15 PM
olasd committed rSPSITE08afd709f9c5: Ensure proper ordering between thanos services and the certificates they use (authored by olasd).
Ensure proper ordering between thanos services and the certificates they use
Jul 13 2022, 6:12 PM
olasd committed rSPSITEe60ee5cf32a2: Use Let's Encrypt to secure thanos gRPC communications (authored by olasd).
Use Let's Encrypt to secure thanos gRPC communications
Jul 13 2022, 6:00 PM
olasd committed rSPSITEd369f42d2d7a: Add support for admin.swh.network in the swh_hostname fact (authored by olasd).
Add support for admin.swh.network in the swh_hostname fact
Jul 13 2022, 6:00 PM
olasd committed rSPSITE54b4db842ae8: Add hostname-based certificates for pergamon and thanos (authored by olasd).
Add hostname-based certificates for pergamon and thanos
Jul 13 2022, 6:00 PM
olasd committed rSPSITEaa477ee7141f: Allow deploying the same letsencrypt certificate to multiple paths (authored by olasd).
Allow deploying the same letsencrypt certificate to multiple paths
Jul 13 2022, 6:00 PM

Jul 12 2022

olasd accepted D8092: Configure thanos query service to new dedicated node.

Looks good to me, thanks!

Jul 12 2022, 10:11 AM
olasd accepted D8106: weekly-planning: Remove 'template' tag from generated documents.

or you could edit on the template directly? [1]

[1] https://hedgedoc.softwareheritage.org/6YKT5osoST-amJQ0MusH2Q?edit

Jul 12 2022, 10:10 AM

Jul 8 2022

olasd accepted D8098: Add a `swh provenance revision from-journal` command.
Jul 8 2022, 5:51 PM
olasd added inline comments to D8092: Configure thanos query service to new dedicated node.
Jul 8 2022, 5:46 PM
olasd requested changes to D8098: Add a `swh provenance revision from-journal` command.

Looks like some copy-and-waste happened here, sorry I hadn't noticed at first !

Jul 8 2022, 2:55 PM
olasd accepted D8100: Add a `swh provenance directory flatten` command.

Nice, thanks!

Jul 8 2022, 2:38 PM
olasd added inline comments to D8098: Add a `swh provenance revision from-journal` command.
Jul 8 2022, 2:38 PM
olasd requested changes to D8100: Add a `swh provenance directory flatten` command.
Jul 8 2022, 2:00 PM
olasd accepted D8099: Remove unused mongo backend.

Welp.

Jul 8 2022, 1:55 PM
olasd added a comment to D8098: Add a `swh provenance revision from-journal` command.

Maybe a new cli test for the revision journal client would be nice

Jul 8 2022, 1:50 PM

Jul 7 2022

olasd added inline comments to D8092: Configure thanos query service to new dedicated node.
Jul 7 2022, 12:09 PM
olasd added inline comments to D8092: Configure thanos query service to new dedicated node.
Jul 7 2022, 12:08 PM
olasd accepted D8068: Do not always auto-create an OriginVisitStatus object in origin_visit_add().

LGTM, thanks!

Jul 7 2022, 11:12 AM

Jul 6 2022

olasd committed rSPSITE260069090f59: thanos sidecar: upload compacted (historical) blocks (authored by olasd).
thanos sidecar: upload compacted (historical) blocks
Jul 6 2022, 4:43 PM
olasd committed rSPSITE63239a2c7926: pergamon: Rename the thanos tenant to a valid azure storage container name (authored by olasd).
pergamon: Rename the thanos tenant to a valid azure storage container name
Jul 6 2022, 4:11 PM
olasd committed rSPSITE21081c8d6f95: Configure prometheus server to support the thanos sidecar (authored by olasd).
Configure prometheus server to support the thanos sidecar
Jul 6 2022, 4:05 PM
olasd committed rSPSITEfd4ce8f1c8d8: Add basic config for a thanos sidecar for prometheus servers (authored by olasd).
Add basic config for a thanos sidecar for prometheus servers
Jul 6 2022, 4:05 PM
olasd committed rSPSITEf5a5e8c6bda0: flatten_to_argument_list: some puppet strings are immutable; always copy them (authored by olasd).
flatten_to_argument_list: some puppet strings are immutable; always copy them
Jul 6 2022, 4:05 PM
olasd committed rSPSITEea7fd0622e97: Changes to /etc/default/prometheus need a service restart (authored by olasd).
Changes to /etc/default/prometheus need a service restart
Jul 6 2022, 4:05 PM
olasd committed rSPSITE44bd5585ff29: Add typing-extensions as dependency for the update-prometheus-config script (authored by olasd).
Add typing-extensions as dependency for the update-prometheus-config script
Jul 6 2022, 4:05 PM
olasd committed rSPSITE941877fb90f0: Ensure the prometheus textfile directory is created after the node exporter… (authored by olasd).
Ensure the prometheus textfile directory is created after the node exporter…
Jul 6 2022, 4:05 PM

Jul 5 2022

olasd committed rSPPRIVC1d7b5f545503: Use objstore instead of objstorage for thanos config (authored by olasd).
Use objstore instead of objstorage for thanos config
Jul 5 2022, 5:23 PM
olasd committed rSPPRIVCce227cb90fbf: Add account key for thanos objstorage (authored by olasd).
Add account key for thanos objstorage
Jul 5 2022, 5:12 PM

Jul 4 2022

olasd removed a watcher for Staff: olasd.
Jul 4 2022, 12:33 PM
olasd added a member for Staff: sgranger.
Jul 4 2022, 12:32 PM
olasd accepted D8045: Add typing to detect_metadata() and related functions.

I'm slightly surprised by the change of signature for translate_directory_intrinsic_metadata without change to the docstring. AFAICT this function now does the detection itself, so maybe it deserves an update.

Jul 4 2022, 11:49 AM

Jun 30 2022

olasd accepted D8062: fix a typo on the production objstorage vhost.

lol

Jun 30 2022, 4:41 PM
olasd committed rSPSITE1fac03d9e685: varnish: use std.lower for compatibility with buster (authored by olasd).
varnish: use std.lower for compatibility with buster
Jun 30 2022, 2:44 PM
olasd committed rDPROVa721125c2a0a: Explicitly manage the provenance storage connection in journal client (authored by olasd).
Explicitly manage the provenance storage connection in journal client
Jun 30 2022, 2:10 PM
olasd committed rDPROVaf616497e108: Isolate journal tests (authored by olasd).
Isolate journal tests
Jun 30 2022, 2:10 PM
olasd added a comment to T4361: Unstuck provenance diff build hanging and then aborted.

It looks like the rabbitmq provenance storage server, which is run within the pytest context through multiprocessing (so forks a bunch of python processes in the pytest run context), interacts poorly with the confluent-kafka library (which is used in the swh.journal fixtures, and brings up a bunch of internal threads).

Jun 30 2022, 11:46 AM · Continuous Integration
olasd updated the diff for D8023: Install `swh provenance origin from-journal` cli and tests.

Drop useless rabbitmq server change

Jun 30 2022, 11:44 AM
olasd updated the diff for D8023: Install `swh provenance origin from-journal` cli and tests.

Ensure coverage results are kept incrementally

Jun 30 2022, 11:34 AM