Page MenuHomeSoftware Heritage
Differential D8221

Make the RPC client raise a specific exception class on 503
ClosedPublic
Actions

Authored by vlorentz on Aug 9 2022, 11:15 AM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Maniphest Tasks
T4427: Deal with recurring Sentry reports of temporary server shutdowns
Commits
rDCOREa0e61ab86973: Make the RPC client raise a specific exception class on 503
Summary

This will be used to make the storage retry proxy retry harder
when the storage server raises errors like psycopg2.OperationalError;
which last longer than we want the proxy to retry for typical
exceptions.

Depends on D8219 and D8220.

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 9 2022, 11:15 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 9 2022, 11:15 AM
swh-public-ci added a comment.Aug 9 2022, 11:17 AM

Build is green

Patch application report for D8221 (id=29656)

Could not rebase; Attempt merge onto 2d1cd6af71...

Updating 2d1cd6a..e06de3a
Fast-forward
 swh/core/api/__init__.py              | 59 +++++++++++++---------------
 swh/core/api/tests/test_rpc_client.py | 37 ++++++++----------
 swh/core/api/tests/test_rpc_server.py | 72 ++++++++++++++++++++++++++++++++++-
 3 files changed, 114 insertions(+), 54 deletions(-)
Changes applied before test
commit e06de3a63b20a685e3acbd26e02ef8353da17fa2
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 9 11:15:05 2022 +0200

    Make the RPC client raise a specific exception class on 503
    
    This will be used to make the storage retry proxy retry harder
    when the storage server raises errors like psycopg2.OperationalError;
    which last longer than we want the proxy to retry for typical
    exceptions.

commit c75ab14ccdc007fa465e421b6aa4290243da96b9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 9 11:12:34 2022 +0200

    Add tests for RPC server's exception handling

commit e6497914d42b1f1e36e2850f53e8b9a04443cbe8
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 9 10:48:22 2022 +0200

    Remove support for deprecated exception format
    
    It was removed from all RPC servers years ago.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/464/ for more details.

Harbormaster completed remote builds in B30719: Diff 29656.Aug 9 2022, 11:17 AM
vlorentz requested review of this revision.Aug 9 2022, 11:17 AM
vlorentz added a task: T4427: Deal with recurring Sentry reports of temporary server shutdowns.Aug 9 2022, 11:18 AM
vlorentz updated this revision to Diff 29660.Aug 9 2022, 2:11 PM

rebase

swh-public-ci added a comment.Aug 9 2022, 2:13 PM

Build is green

Patch application report for D8221 (id=29660)

Could not rebase; Attempt merge onto 2d1cd6af71...

Updating 2d1cd6a..293bd56
Fast-forward
 swh/core/api/__init__.py              | 59 +++++++++++++---------------
 swh/core/api/tests/test_rpc_client.py | 37 ++++++++----------
 swh/core/api/tests/test_rpc_server.py | 74 ++++++++++++++++++++++++++++++++++-
 3 files changed, 115 insertions(+), 55 deletions(-)
Changes applied before test
commit 293bd5650c67b53e922b3a994ec368607f9c8574
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 9 11:15:05 2022 +0200

    Make the RPC client raise a specific exception class on 503
    
    This will be used to make the storage retry proxy retry harder
    when the storage server raises errors like psycopg2.OperationalError;
    which last longer than we want the proxy to retry for typical
    exceptions.

commit 9848432cd77adec649e397c16e76ff8e5865699d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 9 11:12:34 2022 +0200

    Add tests for RPC server's exception handling

commit e6497914d42b1f1e36e2850f53e8b9a04443cbe8
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 9 10:48:22 2022 +0200

    Remove support for deprecated exception format
    
    It was removed from all RPC servers years ago.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/466/ for more details.

Harbormaster completed remote builds in B30723: Diff 29660.Aug 9 2022, 2:13 PM
vlorentz updated this revision to Diff 29663.Aug 9 2022, 3:23 PM

add missing test

swh-public-ci added a comment.Aug 9 2022, 3:25 PM

Build is green

Patch application report for D8221 (id=29663)

Could not rebase; Attempt merge onto 2d1cd6af71...

Updating 2d1cd6a..a0e61ab
Fast-forward
 swh/core/api/__init__.py              | 59 +++++++++++++---------------
 swh/core/api/tests/test_rpc_client.py | 37 ++++++++----------
 swh/core/api/tests/test_rpc_server.py | 74 ++++++++++++++++++++++++++++++++++-
 3 files changed, 115 insertions(+), 55 deletions(-)
Changes applied before test
commit a0e61ab86973f5df3054bd7b343daf59a03415d0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 9 11:15:05 2022 +0200

    Make the RPC client raise a specific exception class on 503
    
    This will be used to make the storage retry proxy retry harder
    when the storage server raises errors like psycopg2.OperationalError;
    which last longer than we want the proxy to retry for typical
    exceptions.

commit 9848432cd77adec649e397c16e76ff8e5865699d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 9 11:12:34 2022 +0200

    Add tests for RPC server's exception handling

commit e6497914d42b1f1e36e2850f53e8b9a04443cbe8
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 9 10:48:22 2022 +0200

    Remove support for deprecated exception format
    
    It was removed from all RPC servers years ago.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/467/ for more details.

Harbormaster completed remote builds in B30726: Diff 29663.Aug 9 2022, 3:25 PM
vlorentz edited the summary of this revision. (Show Details)Aug 9 2022, 3:38 PM
vlorentz added a parent revision: D8220: Add tests for RPC server's exception handling.
vlorentz edited the summary of this revision. (Show Details)
vlorentz added a parent revision: D8219: Remove support for deprecated exception format.
vlorentz added a child revision: D8223: Convert psycopg2 errors to TransientRemoteException instead of RemoteException.Aug 9 2022, 3:39 PM
olasd accepted this revision.Aug 16 2022, 11:13 AM
olasd added a subscriber: olasd.

LGTM, thanks!

This revision is now accepted and ready to land.Aug 16 2022, 11:13 AM
olasd mentioned this in D8223: Convert psycopg2 errors to TransientRemoteException instead of RemoteException.Aug 16 2022, 11:17 AM
Closed by commit rDCOREa0e61ab86973: Make the RPC client raise a specific exception class on 503 (authored by vlorentz). · Explain WhyAug 16 2022, 1:48 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDCOREa0e61ab86973: Make the RPC client raise a specific exception class on 503.

Revision Contents
Changeset List

PathSize
swh/
core/
api/
16 lines
tests/
14 lines

Diff 29756

View Options

swh/core/api/__init__.py

Loading...
View Options

swh/core/api/tests/test_rpc_client.py

Loading...
About · Developer information · Legal