Page MenuHomeSoftware Heritage
Feed Advanced Search

Feb 16 2022

douardda updated the diff for D7188: Make get_sql_for_package() return pathlib.Path objects.

split the git revision in 2

Feb 16 2022, 3:57 PM
douardda updated the diff for D7155: Refactor swh.core.db.pytest_plugin.

rebase

Feb 16 2022, 3:56 PM
douardda updated the diff for D7064: Add a 'swh db upgrade' command.

don't remember...

Feb 16 2022, 3:56 PM
douardda added a comment to D7188: Make get_sql_for_package() return pathlib.Path objects.

This also comes with a change in expected test data structure for sql script

please mention this in the first line of the commit msg (or ideally, in a separate commit)

Feb 16 2022, 3:11 PM
douardda updated the diff for D7189: Prevent root conftest.py from loading swh.core at module loading time.

rebase

Feb 16 2022, 3:07 PM
douardda updated the diff for D7159: Add a documentation section for swh.core.db.

rebase

Feb 16 2022, 3:07 PM
douardda updated the diff for D7188: Make get_sql_for_package() return pathlib.Path objects.

rebase

Feb 16 2022, 3:06 PM
douardda updated the diff for D7155: Refactor swh.core.db.pytest_plugin.

rebase

Feb 16 2022, 3:06 PM
douardda updated the diff for D7064: Add a 'swh db upgrade' command.

rebase + more fixes suggested by ardumont and vlorentz

Feb 16 2022, 3:06 PM
douardda updated the diff for D7063: Make 'swh db init' fill the dbversion table.

rebase

Feb 16 2022, 3:05 PM
douardda updated the diff for D7170: Use a standard postgresql db fixture in test_cli.

rebase

Feb 16 2022, 3:04 PM
douardda updated the diff for D7062: Add support for dbversion and dbmodule handling in swh db init.

fix copyrights

Feb 16 2022, 3:03 PM
douardda added inline comments to D7064: Add a 'swh db upgrade' command.
Feb 16 2022, 2:50 PM
douardda added inline comments to D7064: Add a 'swh db upgrade' command.
Feb 16 2022, 2:39 PM
douardda updated the diff for D7189: Prevent root conftest.py from loading swh.core at module loading time.

rebase

Feb 16 2022, 2:27 PM
douardda updated the diff for D7159: Add a documentation section for swh.core.db.

rebase

Feb 16 2022, 2:27 PM
douardda updated the diff for D7188: Make get_sql_for_package() return pathlib.Path objects.

rebase

Feb 16 2022, 2:26 PM
douardda updated the diff for D7155: Refactor swh.core.db.pytest_plugin.

typos and fixes suggested by ardumon

Feb 16 2022, 2:26 PM
douardda added inline comments to D7155: Refactor swh.core.db.pytest_plugin.
Feb 16 2022, 2:24 PM
douardda added inline comments to D7064: Add a 'swh db upgrade' command.
Feb 16 2022, 2:05 PM
douardda updated the diff for D7189: Prevent root conftest.py from loading swh.core at module loading time.

rebase

Feb 16 2022, 2:04 PM
douardda updated the diff for D7159: Add a documentation section for swh.core.db.

rebase

Feb 16 2022, 2:03 PM
douardda updated the diff for D7188: Make get_sql_for_package() return pathlib.Path objects.

rebase

Feb 16 2022, 2:03 PM
douardda updated the diff for D7155: Refactor swh.core.db.pytest_plugin.

rebase

Feb 16 2022, 2:03 PM
douardda updated the diff for D7064: Add a 'swh db upgrade' command.

docstring and fix in get_sql_for_package

Feb 16 2022, 2:02 PM
douardda updated the summary of D7159: Add a documentation section for swh.core.db.
Feb 16 2022, 1:50 PM
douardda updated the diff for D7189: Prevent root conftest.py from loading swh.core at module loading time.

rebase

Feb 16 2022, 1:49 PM
douardda updated the diff for D7159: Add a documentation section for swh.core.db.

gazillion of typos (+ fix erroneous cfg example file)

Feb 16 2022, 1:48 PM
douardda added inline comments to D7159: Add a documentation section for swh.core.db.
Feb 16 2022, 1:46 PM
douardda requested review of D7189: Prevent root conftest.py from loading swh.core at module loading time.
Feb 16 2022, 1:27 PM
douardda requested review of D7188: Make get_sql_for_package() return pathlib.Path objects.
Feb 16 2022, 1:26 PM
douardda updated the diff for D7159: Add a documentation section for swh.core.db.

rebase

Feb 16 2022, 1:24 PM
douardda updated the diff for D7155: Refactor swh.core.db.pytest_plugin.

rebas

Feb 16 2022, 1:23 PM
douardda updated the diff for D7064: Add a 'swh db upgrade' command.

typos and add missing docstrings

Feb 16 2022, 1:22 PM

Feb 15 2022

douardda updated the diff for D7064: Add a 'swh db upgrade' command.

typos, add sanity check in the 'swh db upgrade' command, add tests

Feb 15 2022, 5:17 PM
douardda requested review of D7170: Use a standard postgresql db fixture in test_cli.
Feb 15 2022, 2:22 PM
douardda renamed T3730: Add a "user support" mechanism to the archive from Add a "user support" mechanism in the archive to Add a "user support" mechanism to the archive.
Feb 15 2022, 1:36 PM · meta-task, Roadmap 2022
douardda triaged T3934: Publish up-to-date docker images as Normal priority.
Feb 15 2022, 1:29 PM · System administration

Feb 14 2022

douardda updated the summary of D7063: Make 'swh db init' fill the dbversion table.
Feb 14 2022, 1:51 PM
douardda updated the diff for D7159: Add a documentation section for swh.core.db.

rebase

Feb 14 2022, 1:51 PM
douardda updated the diff for D7155: Refactor swh.core.db.pytest_plugin.

rebase

Feb 14 2022, 1:50 PM
douardda updated the diff for D7064: Add a 'swh db upgrade' command.

rebase

Feb 14 2022, 1:50 PM
douardda updated the diff for D7063: Make 'swh db init' fill the dbversion table.

rebas

Feb 14 2022, 1:49 PM
douardda updated the diff for D7062: Add support for dbversion and dbmodule handling in swh db init.

typos (thx ardumont)

Feb 14 2022, 1:47 PM
douardda added inline comments to D7062: Add support for dbversion and dbmodule handling in swh db init.
Feb 14 2022, 1:43 PM
douardda added inline comments to D7062: Add support for dbversion and dbmodule handling in swh db init.
Feb 14 2022, 1:35 PM
douardda closed D7161: Ensure the vault instance used in tests is recreated.
Feb 14 2022, 12:38 PM
douardda committed rDVAUdccc245a01ae: Ensure the vault instance used in tests is recreated (authored by douardda).
Ensure the vault instance used in tests is recreated
Feb 14 2022, 12:38 PM
douardda updated the diff for D7161: Ensure the vault instance used in tests is recreated.

add a comment

Feb 14 2022, 12:18 PM
douardda added a comment to T3930: Update swh-search QL examples.

I agree that having actually "working" examples in the doc is a must.

Feb 14 2022, 11:54 AM · Documentation, Archive search

Feb 11 2022

douardda added a revision to T3894: Add a 'swh db upgrade' cli: D7165: Adapt scheduler to swh.core 2.0.0.
Feb 11 2022, 5:14 PM · Core & foundations
douardda added a revision to T3894: Add a 'swh db upgrade' cli: D7164: Adapt indexer to swh.core 2.0.0.
Feb 11 2022, 5:08 PM · Core & foundations
douardda added a revision to T3894: Add a 'swh db upgrade' cli: D7162: Adapt vault to swh-core 2.0.0.
Feb 11 2022, 4:39 PM · Core & foundations
douardda requested review of D7161: Ensure the vault instance used in tests is recreated.
Feb 11 2022, 4:37 PM
douardda requested review of D7159: Add a documentation section for swh.core.db.
Feb 11 2022, 4:31 PM
douardda updated the diff for D7155: Refactor swh.core.db.pytest_plugin.

rebase

Feb 11 2022, 4:29 PM
douardda updated the diff for D7064: Add a 'swh db upgrade' command.

typos

Feb 11 2022, 4:28 PM
douardda updated the diff for D7063: Make 'swh db init' fill the dbversion table.

typos

Feb 11 2022, 4:27 PM
douardda added a revision to T3894: Add a 'swh db upgrade' cli: D7160: Update storage for swh.core 2.0.0.
Feb 11 2022, 4:20 PM · Core & foundations
douardda updated the diff for D7155: Refactor swh.core.db.pytest_plugin.

small fix

Feb 11 2022, 3:56 PM
douardda updated the diff for D7155: Refactor swh.core.db.pytest_plugin.

rebase and print/pass statements

Feb 11 2022, 2:38 PM
douardda updated the diff for D7064: Add a 'swh db upgrade' command.

rebase

Feb 11 2022, 2:34 PM
douardda updated the diff for D7063: Make 'swh db init' fill the dbversion table.

rebase

Feb 11 2022, 2:33 PM
douardda updated the diff for D7062: Add support for dbversion and dbmodule handling in swh db init.

typos

Feb 11 2022, 2:32 PM
douardda added inline comments to D7063: Make 'swh db init' fill the dbversion table.
Feb 11 2022, 2:29 PM
douardda added a comment to D7062: Add support for dbversion and dbmodule handling in swh db init.
In D7062#183909, @olasd wrote:

Thanks, this looks like a good step forward!

These "Also" changes would have been much easier to review (and land) as separate diffs; they're probably uncontroversial, but I'm not sure what they really are by looking at this diff :-)

Feb 11 2022, 2:13 PM
douardda closed D7153: Fix a bug in numfile_sortkey and add tests for it.
Feb 11 2022, 12:52 PM
douardda closed D7152: Convert test_utils to pytest.
Feb 11 2022, 12:52 PM
douardda committed rDCORE3139d3344e23: Fix a bug in numfile_sortkey and add tests for it (authored by douardda).
Fix a bug in numfile_sortkey and add tests for it
Feb 11 2022, 12:52 PM
douardda committed rDCORE68dc6811967f: Convert test_utils to pytest (authored by douardda).
Convert test_utils to pytest
Feb 11 2022, 12:52 PM
douardda closed D7061: Make `swh db init` retrieve the db cnx uri from the config file.
Feb 11 2022, 12:52 PM
douardda committed rDCORE3e43730df615: Make `swh db init` retrieve the db cnx uri from the config file (authored by douardda).
Make `swh db init` retrieve the db cnx uri from the config file
Feb 11 2022, 12:52 PM
douardda committed rDCORE459da96c1e6b: Move utility functions from cli.db to db.db_utils (authored by douardda).
Move utility functions from cli.db to db.db_utils
Feb 11 2022, 12:52 PM
douardda closed D7060: preparation refactoring for following diffs.
Feb 11 2022, 12:52 PM
douardda committed rDCORE932eed4863ba: Remove the old and unused log-schema.sql file (authored by douardda).
Remove the old and unused log-schema.sql file
Feb 11 2022, 12:52 PM
douardda added a comment to D7153: Fix a bug in numfile_sortkey and add tests for it.

You could also return float("infinity") just to be sure :)

I actually though about it, but then it would make the typing more complex for no real reason :-)

Feb 11 2022, 12:51 PM
douardda added a comment to D7153: Fix a bug in numfile_sortkey and add tests for it.

You could also return float("infinity") just to be sure :)

Feb 11 2022, 12:50 PM
douardda requested review of D7155: Refactor swh.core.db.pytest_plugin.
Feb 11 2022, 12:49 PM
douardda updated the diff for D7064: Add a 'swh db upgrade' command.

rebase

Feb 11 2022, 12:28 PM
douardda updated the diff for D7063: Make 'swh db init' fill the dbversion table.

rebase

Feb 11 2022, 12:27 PM
douardda updated the summary of D7062: Add support for dbversion and dbmodule handling in swh db init.
Feb 11 2022, 12:24 PM
douardda requested review of D7154: Refactor the mock_package_sql fixture to allow multiple sql script set.
Feb 11 2022, 12:24 PM
douardda updated the diff for D7062: Add support for dbversion and dbmodule handling in swh db init.

rebase and extracted D7154 as a standolone diff

Feb 11 2022, 12:24 PM
douardda requested review of D7153: Fix a bug in numfile_sortkey and add tests for it.
Feb 11 2022, 12:22 PM
douardda requested review of D7152: Convert test_utils to pytest.
Feb 11 2022, 12:22 PM
douardda updated the diff for D7061: Make `swh db init` retrieve the db cnx uri from the config file.

rebase

Feb 11 2022, 12:19 PM
douardda updated the diff for D7060: preparation refactoring for following diffs.

rebase

Feb 11 2022, 12:19 PM

Feb 9 2022

douardda committed rDSCHc46ffadf7adf: Prefix task types used in tests with 'test-' (authored by douardda).
Prefix task types used in tests with 'test-'
Feb 9 2022, 10:26 AM
douardda closed D7125: Prefix task types used in tests with 'test-'.
Feb 9 2022, 10:26 AM

Feb 8 2022

douardda requested review of D7125: Prefix task types used in tests with 'test-'.
Feb 8 2022, 5:37 PM

Feb 7 2022

douardda added a comment to D7062: Add support for dbversion and dbmodule handling in swh db init.
In D7062#183909, @olasd wrote:

Thanks, this looks like a good step forward!

These "Also" changes would have been much easier to review (and land) as separate diffs; they're probably uncontroversial, but I'm not sure what they really are by looking at this diff :-)

Feb 7 2022, 3:18 PM
douardda added a comment to T3890: schema of timezones in the journal.

Looks like we are going to keep the status quo in the short term, ie. a numeric offset for old objects, and offset_bytes for new objects without renaming.

@douardda @olasd agreed?

Feb 7 2022, 9:46 AM · Journal, Data Model

Feb 4 2022

douardda accepted D7069: Add typing to revision_walker.py and make the state a dataclass.

probably need to update the docstring, otherwise ok

Feb 4 2022, 4:10 PM
douardda added inline comments to D7069: Add typing to revision_walker.py and make the state a dataclass.
Feb 4 2022, 4:09 PM
douardda added a comment to D7069: Add typing to revision_walker.py and make the state a dataclass.

lgtm but as said on IRC, it's not just a type annotation diff, it does modify the code (introduce the State dataclass etc)

Feb 4 2022, 11:27 AM

Feb 2 2022

douardda added a comment to T3894: Add a 'swh db upgrade' cli.

To help a bit, here is the plan:

Feb 2 2022, 4:10 PM · Core & foundations
douardda updated the diff for D7064: Add a 'swh db upgrade' command.

rebase

Feb 2 2022, 3:53 PM
douardda updated the diff for D7063: Make 'swh db init' fill the dbversion table.

rebase

Feb 2 2022, 3:53 PM
douardda updated the diff for D7062: Add support for dbversion and dbmodule handling in swh db init.

rebase

Feb 2 2022, 3:53 PM
douardda updated the diff for D7061: Make `swh db init` retrieve the db cnx uri from the config file.

improve help for 'swh db init' as suggested by vlorentz

Feb 2 2022, 3:52 PM