Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3894: Add a 'swh db upgrade' cli

Commits

rDCIDX9e89b83be455: Adapt to swh.core 2.0.0

Summary

add the get_datastore function in swh.indexer
add the get_current_version method in IndexerBackend,
remove dbversion management from sql init script
update tests accordingly

Depends on D7155
Related to T3894

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Feb 11 2022, 5:08 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 11 2022, 5:08 PM

Build has FAILED

Patch application report for D7164 (id=25966)

Rebasing onto 38bae9837b...

Current branch diff-target is up to date.

Changes applied before test

commit c2758e6547ede817b1d7cf2bd05c3aa6798b56b5
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Feb 8 14:57:30 2022 +0100

    Adapt to swh.core  2.0.0
    
    - add the `get_datastore` function in `swh.indexer`
    - add the `get_current_version` method in `IndexerBackend`,
    - remove dbversion management from sql init script
    - update tests accordingly

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/189/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/189/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 11 2022, 5:09 PM

Harbormaster failed remote builds in B26842: Diff 25966!

douardda retitled this revision from Adapt to swh.core 2.0.0 to Adapt indexer to swh.core 2.0.0.Feb 11 2022, 5:13 PM

Build has FAILED

Patch application report for D7164 (id=25966)

Rebasing onto 38bae9837b...

Current branch diff-target is up to date.

Changes applied before test

commit c2758e6547ede817b1d7cf2bd05c3aa6798b56b5
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Feb 8 14:57:30 2022 +0100

    Adapt to swh.core  2.0.0
    
    - add the `get_datastore` function in `swh.indexer`
    - add the `get_current_version` method in `IndexerBackend`,
    - remove dbversion management from sql init script
    - update tests accordingly

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/190/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/190/console

small flake8 and mypy fixes

Build has FAILED

Patch application report for D7164 (id=26205)

Rebasing onto 38bae9837b...

Current branch diff-target is up to date.

Changes applied before test

commit d400d5161b2c447636b6485d86f2e4d1ff5b1af0
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Feb 8 14:57:30 2022 +0100

    Adapt to swh.core  2.0.0
    
    - add the `get_datastore` function in `swh.indexer`
    - add the `get_current_version` method in `IndexerBackend`,
    - remove dbversion management from sql init script
    - update tests accordingly

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/191/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/191/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 23 2022, 2:36 PM

Harbormaster failed remote builds in B27078: Diff 26205!

forgot to commit requirements file

Build has FAILED

Patch application report for D7164 (id=26207)

Rebasing onto 38bae9837b...

Current branch diff-target is up to date.

Changes applied before test

commit 8cb650cab81c4067be24fcaeb41150ff81558fe7
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Feb 8 14:57:30 2022 +0100

    Adapt to swh.core  2.0.0
    
    - add the `get_datastore` function in `swh.indexer`
    - add the `get_current_version` method in `IndexerBackend`,
    - remove dbversion management from sql init script
    - update tests accordingly

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/192/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/192/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 23 2022, 2:56 PM

Harbormaster failed remote builds in B27080: Diff 26207!

rebase

Build is green

Patch application report for D7164 (id=26236)

Rebasing onto 12c3f4cf87...

Current branch diff-target is up to date.

Changes applied before test

commit 9fb219a65d01b32c421808d9904373f5d07ba7db
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Feb 8 14:57:30 2022 +0100

    Adapt to swh.core  2.0.0
    
    - add the `get_datastore` function in `swh.indexer`
    - add the `get_current_version` method in `IndexerBackend`,
    - remove dbversion management from sql init script
    - update tests accordingly

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/195/ for more details.

Harbormaster completed remote builds in B27109: Diff 26236.Feb 24 2022, 11:18 AM

douardda requested review of this revision.Feb 24 2022, 11:18 AM

vlorentz added a subscriber: vlorentz.Feb 24 2022, 11:21 AM

vlorentz added inline comments.

requirements-test.txt
10 ↗	(On Diff #26236)	why?

lgtm

This revision is now accepted and ready to land.Feb 24 2022, 12:04 PM

douardda added inline comments.Feb 24 2022, 12:05 PM

requirements-test.txt
10 ↗	(On Diff #26236)	why? because mypy told me so (did not dig further, just did what I was told)

remove the dep on types-toml

seems not needed after all.

douardda marked an inline comment as done.Feb 24 2022, 5:23 PM

Build is green

Patch application report for D7164 (id=26285)

Rebasing onto 12c3f4cf87...

Current branch diff-target is up to date.

Changes applied before test

commit 9e89b83be45582d7b709f192a83d14c7433641f2
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Feb 8 14:57:30 2022 +0100

    Adapt to swh.core  2.0.0
    
    - add the `get_datastore` function in `swh.indexer`
    - add the `get_current_version` method in `IndexerBackend`,
    - remove dbversion management from sql init script
    - update tests accordingly

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/196/ for more details.

Harbormaster completed remote builds in B27157: Diff 26285.Feb 24 2022, 5:27 PM

Closed by commit rDCIDX9e89b83be455: Adapt to swh.core 2.0.0 (authored by douardda). · Explain WhyFeb 24 2022, 5:33 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDCIDX9e89b83be455: Adapt to swh.core 2.0.0.

Adapt indexer to swh.core 2.0.0ClosedPublicActions

Details

Diff Detail

Event Timeline

Patch application report for D7164 (id=25966)

Changes applied before test

Patch application report for D7164 (id=25966)

Changes applied before test

Patch application report for D7164 (id=26205)

Changes applied before test

Patch application report for D7164 (id=26207)

Changes applied before test

Patch application report for D7164 (id=26236)

Changes applied before test

Patch application report for D7164 (id=26285)

Changes applied before test

Revision ContentsChangeset List

Diff 26286

sql/upgrades/115.sql

sql/upgrades/116.sql

sql/upgrades/117.sql

sql/upgrades/118.sql

sql/upgrades/119.sql

sql/upgrades/120.sql

sql/upgrades/121.sql

sql/upgrades/122.sql

sql/upgrades/123.sql

sql/upgrades/124.sql

sql/upgrades/125.sql

sql/upgrades/126.sql

sql/upgrades/127.sql

sql/upgrades/128.sql

sql/upgrades/129.sql

sql/upgrades/130.sql

sql/upgrades/131.sql

sql/upgrades/132.sql

sql/upgrades/133.sql

swh/indexer/__init__.py

swh/indexer/sql/30-schema.sql

swh/indexer/sql/upgrades/115.sql

swh/indexer/sql/upgrades/116.sql

swh/indexer/sql/upgrades/117.sql

swh/indexer/sql/upgrades/118.sql

swh/indexer/sql/upgrades/119.sql

swh/indexer/sql/upgrades/120.sql

swh/indexer/sql/upgrades/121.sql

swh/indexer/sql/upgrades/122.sql

swh/indexer/sql/upgrades/123.sql

swh/indexer/sql/upgrades/124.sql

swh/indexer/sql/upgrades/125.sql

swh/indexer/sql/upgrades/126.sql

swh/indexer/sql/upgrades/127.sql

swh/indexer/sql/upgrades/128.sql

swh/indexer/sql/upgrades/129.sql

swh/indexer/sql/upgrades/130.sql

swh/indexer/sql/upgrades/131.sql

swh/indexer/sql/upgrades/132.sql

swh/indexer/sql/upgrades/133.sql

swh/indexer/storage/__init__.py

swh/indexer/storage/db.py

swh/indexer/tests/conftest.py

swh/indexer/tests/storage/__init__.py

swh/indexer/tests/storage/conftest.py

Adapt indexer to swh.core 2.0.0
ClosedPublic
Actions

Revision Contents
Changeset List

swh/indexer/init.py

swh/indexer/storage/init.py

swh/indexer/tests/storage/init.py