Looks good to me !
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jan 25 2021
Build is green
improve handling of credentials
Looks good to me !
Build is green
- rebase
- update tests according to the review feedbacks
Jan 22 2021
thanks. I think however, given its purpose, this example code should be heavily commented: each constant (eg. MyPageType) and each method should be commented (not docstrings but comments exaplaining what the method/variable is used for).
Jan 21 2021
Jan 20 2021
Build is green
Remove "WIP" from the commit message
Remove the lister model
Jan 19 2021
Looks good to me, time to land this !
Build is green
Clean code and fix page type
Build is green
Revert changes to the credentials setting method, and improve corresponding test
Build is green
Remove tenacity wait parameter
Build is green
Remove the persistent isort conftest modification from diff
Jan 18 2021
Build is green
Have test coverage for credentials setting
Build is green
Looks fine to me, thanks. Please apply @anlambert's remaining comments before landing! :)
Build is green
- fix assert
- fix typing
- add a warning on credentials
Jan 17 2021
Build is green
- remove useless code as per feeback
- improve tests
Jan 15 2021
In short, let's KISS!