In D2794#66864, @vlorentz wrote:

Now that swh-scanner has tests, it would be nice if every new feature and bugfix added (or changed) one or more tests.

make tox pass

rebase

if a symbolic link is encountered, the persistent identifier is parsed by pid_of_file (as in swh.model)

rebase

comments

In D2785#66652, @vlorentz wrote:

In D2785#66602, @DanSeraf wrote:

In D2785#66553, @vlorentz wrote:

When does this happen? Could you add a test for this behavior?

When, for example, there is a broken symlink. It can't read if it's a file or a directory.

Could you add this as a comment?

In D2791#66642, @vlorentz wrote:

I'm restarting the tests

clean flask_api.py

make flake8 pass

In D2785#66553, @vlorentz wrote:

When does this happen? Could you add a test for this behavior?

cli: --format option, text and json
model:

• changed function name from getJsonChild to getJsonTree
• show function: output based on format

cli: flake8

• cli: scanner group with scan option, updated description
• color only when stdout is connected to terminal

In D2657#65016, @vlorentz wrote:

It's still missing a description of what it does (ie. check that files exist in swh), in the CLI help and/or README.

and I still think you should use a subcommand, in case you want to add new features in the future without breaking scripts that depend on this one.

In D2657#64937, @ardumont wrote:

rebase

limit is set inside the endpoint

rebase

In D2582#61590, @vlorentz wrote:

I think you missed this comment: https://forge.softwareheritage.org/D2582?id=9215#inline-17178

In D2582#61501, @vlorentz wrote:

• returning 400 instead of 500 for invalid pid, type annotation on lookup_missing_hashes

This part is ok now, but cf my earlier comment: "You should add a small wrapper around parse_persistent_identifier to handle the error, that can be shared with resolve_swh_persistent_id."

• returning 400 instead of 500 for invalid pid, type annotation on lookup_missing_hashes
• rebase

• /known/ endpoint tests
• test_service: testing missing hashes lookup with present pids

• known moved to identifiers view, parse pids before grouping them
• test present pids

• storage: Add endpoint to get missing content (by sha1_git) and missing snapshot
• in memory changes
• test endpoint: content_missing (sha1_git), snapshot_missing
• assert list doesn't have too many values

• assert list doesn't have too many values

• in memory changes
• test endpoint: content_missing (sha1_git), snapshot_missing

thanks a lot @DanSeraf!, this has now been accepted, landed to master, and you've been added to the CONTRIBUTORS file :-)

Closes: T1986

test_identifiers: checking exception type instead of exception string