Details

swh/scanner/exceptions.py
13–15 ↗	(On Diff #9942)	nitpick: inconsistent casing, and s/request/requests/
20 ↗	(On Diff #9942)	You can probably use `resp.reason` instead of `status_code_msg[resp.status]`

vlorentz requested changes to this revision.Mar 10 2020, 12:18 PM

This revision now requires changes to proceed.Mar 10 2020, 12:18 PM

In D2794#66864, @vlorentz wrote:

Now that swh-scanner has tests, it would be nice if every new feature and bugfix added (or changed) one or more tests.

Yes, i'll write test also on this one

assert APIError raises when the payload is too large
live_server override, only one per session

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DTSCN/job/tox/11/
See console output for more information: https://jenkins.softwareheritage.org/job/DTSCN/job/tox/11/console

Harbormaster failed remote builds in B11023: Diff 9952!Mar 10 2020, 3:11 PM

flake8

Build is green
See https://jenkins.softwareheritage.org/job/DTSCN/job/tox/12/ for more details.

Harbormaster completed remote builds in B11025: Diff 9954.Mar 10 2020, 3:16 PM

rebase

Build is green
See https://jenkins.softwareheritage.org/job/DTSCN/job/tox/13/ for more details.

Harbormaster completed remote builds in B11037: Diff 9965.Mar 10 2020, 6:03 PM

vlorentz accepted this revision.Mar 10 2020, 7:50 PM

vlorentz added inline comments.

swh/scanner/tests/conftest.py
63–66 ↗	(On Diff #9965)	slightly confusing, but ok. Maybe a comment?
swh/scanner/tests/test_scanner.py
45 ↗	(On Diff #9965)	You can also use the `match` argument in APIError to check the reason is there, but that's not very important