Paths

Table of Contentst

Differential D2570

storage: Add endpoint to get missing content (by sha1_git) and missing snapshot
ClosedPublic
Actions

Authored by DanSeraf on Jan 22 2020, 1:29 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDSTO2ebce62ef4ed: test endpoint: content_missing (sha1_git), snapshot_missing
rDSTOcc2581008a7d: assert list doesn't have too many values
rDSTOc40d327e44df: in memory changes
rDSTO55ebd23f5176: storage: Add endpoint to get missing content (by sha1_git) and missing snapshot

Summary

Storage support for the web API endpoint /known/ (T2176)

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

DanSeraf created this revision.Jan 22 2020, 1:29 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 22 2020, 1:29 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/873/ for more details.

Harbormaster completed remote builds in B10231: Diff 9170.Jan 22 2020, 1:33 PM

Looks good, but this diff is missing tests and matching changes in in_memory.py

vlorentz requested changes to this revision.Jan 22 2020, 1:50 PM

This revision now requires changes to proceed.Jan 22 2020, 1:50 PM

in memory changes
test endpoint: content_missing (sha1_git), snapshot_missing

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/874/ for more details.

Harbormaster completed remote builds in B10234: Diff 9173.Jan 22 2020, 2:33 PM

Two more comments, and it should be good to merge

swh/storage/tests/test_storage.py
381 ↗	(On Diff #9173)	Could you use equality instead, to check `content_missing_per_sha1_git` doesn't return too many results?
2598 ↗	(On Diff #9173)	same

This revision now requires changes to proceed.Jan 22 2020, 2:39 PM

DanSeraf added inline comments.Jan 22 2020, 2:53 PM

swh/storage/tests/test_storage.py
381 ↗	(On Diff #9173)	It returns only the missing content sha1_git, one in that case.

vlorentz added inline comments.Jan 22 2020, 2:55 PM

swh/storage/tests/test_storage.py
381 ↗	(On Diff #9173)	What I mean is that we want the test to check that `missing_contents` can't be something like `[None, None missing_cont['sha1_git'], None]`

DanSeraf added inline comments.Jan 22 2020, 3:01 PM

swh/storage/tests/test_storage.py
381 ↗	(On Diff #9173)	Ok, i get it.

assert list doesn't have too many values

vlorentz accepted this revision.Jan 22 2020, 3:12 PM

This revision is now accepted and ready to land.Jan 22 2020, 3:12 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/877/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/878/ for more details.

Harbormaster completed remote builds in B10237: Diff 9178.Jan 22 2020, 3:25 PM

storage: Add endpoint to get missing content (by sha1_git) and missing snapshot
in memory changes
test endpoint: content_missing (sha1_git), snapshot_missing
assert list doesn't have too many values

This revision was landed with ongoing or failed builds.Jan 22 2020, 3:55 PM

Closed by commit rDSTO55ebd23f5176: storage: Add endpoint to get missing content (by sha1_git) and missing snapshot (authored by DanSeraf). · Explain Why

This revision was automatically updated to reflect the committed changes.

DanSeraf added a commit: rDSTO55ebd23f5176: storage: Add endpoint to get missing content (by sha1_git) and missing snapshot.

DanSeraf added a commit: rDSTOc40d327e44df: in memory changes.

DanSeraf added a commit: rDSTO2ebce62ef4ed: test endpoint: content_missing (sha1_git), snapshot_missing.

DanSeraf added a commit: rDSTOcc2581008a7d: assert list doesn't have too many values.

Harbormaster failed remote builds in B10239: Diff 9186!Jan 22 2020, 3:55 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/879/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/879/console

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/880/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/880/console

Revision Contents
Changeset List

Path

Size

swh/

storage/

19 lines

31 lines

Diff 9187

swh/storage/db.py

Loading...

swh/storage/storage.py

Loading...