Rebasing on master.

Use aiohttp.test_utils.unused_port()

• Use any available port for server/client interaction
• Add version constant in tests

• Use isinstance instead of type
• Simplify pathlib paths
• Use sets to compare stats json keys

• Do not yield unused server internal variable
• Use pathlib instead of os.path
• Remove unittest test case
• Stronger assertions on types and values in test_stats

In D1768#41639, @zack wrote:

In D1768#41627, @haltode wrote:

The mapping has always been a separate command but we can indeed add it to the generate_graph.sh script.

Oh, ok, that explains it.

That means that the README on how to recreate the testdata isn't correct at present (or at least it's incomplete).

Integrate this into generate_graph.sh is a good idea. When it's done, we can also further simplify docs/docker.rst.

In D1768#41626, @zack wrote:

Note that this diff still makes the test fail after re-running generate_graph.sh, because apparently the mappings are no longer generated. (Although it doesn't seem compress_graph.sh has ever generated them, so I'm not sure it's related to this diff [?]).

One test call per endpoint seems enough right now, the Python side relies entirely on swh custom REST API class for client <-> server interaction (which has tests on its own).

Running swh-graph (with only the default graph not its transposed) requires ~125GB of RAM.

What kind of tests do we want for the client side code? Checking the resulting json format for each endpoints?

I'm not sure to understand why we cannot use like the others URL (https://docs.softwareheritage.org/devel/http-routingtable.html) a sub-endpoint /graph.

Awesome, thanks a lot for this diff!

Rebasing on master

Yes this is related, there are safe checks when creating a new SwhId from a string form, and right now the code for the type looks like:

Closed by commit ebfa6310c5ab.

Use special null value in boolean array to quickly bypass edge check when no
edge restriction is enforced.

Use local variables instead of class variable (more functional and fix
multithreading issues).

Remove code duplication.

Move bypass check to Neighbors iterator upper-level class.

Rebasing on master.

Concerning links to swh-graph/docs it needs to wait for integration with swh-docs and then add external html links.

Fix grammar/style issues.

In D1741#40365, @zack wrote:

in addition to the comments below, a general issue is that all verbs are in the third person (e.g., "returns foo", "converts bla"), while it is more idiomatic to use the infinitive in API documentation (e.g., "return foo", "convert bla").

From the sphinx-maven plugin documentation :

Update commit message (one task per "close" line)

Awesome doc, thanks! Here are a few quick comments.