Page MenuHomeSoftware Heritage
Differential D1736

Separate id mapping from traversals using node2type map
ClosedPublic
Actions

Authored by haltode on Jul 15 2019, 2:42 PM.

Details

Reviewers
zack
Maniphest Tasks
T1898: swh-graph: refactor algo implementations to not forcibly memoize results
T1901: refactor graph API to use integer IDs in the kernel and translate to/from SWH PIDs on outer layers
T1902: Use in-memory bitmap to store node->types relations in graph API
Commits
rDGRPHd56bfa886d2e: server: separate id mapping from traversals using node2type map
Summary

algo/Traversal.java now only uses internal ids and Endpoint.java is
responsible of input/output id conversion.

Closes T1898, T1901 and T1902.

Diff Detail

Repository
rDGRPH Compressed graph representation
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

haltode created this revision.Jul 15 2019, 2:42 PM
Harbormaster completed remote builds in B6867: Diff 5828.Jul 15 2019, 2:42 PM
haltode edited the summary of this revision. (Show Details)Jul 15 2019, 3:20 PM
haltode added a task: T1898: swh-graph: refactor algo implementations to not forcibly memoize results.
zack accepted this revision.Jul 16 2019, 9:37 AM

as a minor point on the commit message, I think you need separate Closes lines to close several bugs with a commit at once

This revision is now accepted and ready to land.Jul 16 2019, 9:37 AM
haltode updated this revision to Diff 5842.Jul 16 2019, 9:39 AM

Update commit message (one task per "close" line)

Harbormaster completed remote builds in B6881: Diff 5842.Jul 16 2019, 9:39 AM
Closed by commit rDGRPHd56bfa886d2e: server: separate id mapping from traversals using node2type map (authored by haltode). · Explain WhyJul 16 2019, 9:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
api/
server/
src/
main/
java/
org/
softwareheritage/
graph/
16 lines
22 lines
85 lines
12 lines
5 lines
algo/
197 lines
backend/
8 lines
benchmark/
6 lines
test/
java/
org/
softwareheritage/
graph/
25 lines
28 lines
62 lines
89 lines
46 lines

Diff 5843

View Options

api/server/src/main/java/org/softwareheritage/graph/AllowedEdges.java

Loading...
View Options

api/server/src/main/java/org/softwareheritage/graph/App.java

Loading...
View Options

api/server/src/main/java/org/softwareheritage/graph/Endpoint.java

Loading...
View Options

api/server/src/main/java/org/softwareheritage/graph/Neighbors.java

Loading...
View Options

api/server/src/main/java/org/softwareheritage/graph/SwhPath.java

Loading...
View Options

api/server/src/main/java/org/softwareheritage/graph/algo/Traversal.java

Loading...
View Options

api/server/src/main/java/org/softwareheritage/graph/backend/Setup.java

Loading...
View Options

api/server/src/main/java/org/softwareheritage/graph/benchmark/LinuxLog.java

Loading...
View Options

api/server/src/test/java/org/softwareheritage/graph/AllowedEdgesTest.java

Loading...
View Options

api/server/src/test/java/org/softwareheritage/graph/LeavesTest.java

Loading...
View Options

api/server/src/test/java/org/softwareheritage/graph/NeighborsTest.java

Loading...
View Options

api/server/src/test/java/org/softwareheritage/graph/VisitTest.java

Loading...
View Options

api/server/src/test/java/org/softwareheritage/graph/WalkTest.java

Loading...
About · Developer information · Legal