Page MenuHomeSoftware Heritage

Remove visit/ endpoint and keep only: visit/nodes visit/paths
ClosedPublic

Authored by haltode on Mon, Jul 29, 4:10 PM.

Details

Summary

Returning both nodes and paths adds unnecessary convoluted code in the
client and server code. In addition, the global 'visit/' endpoint is not
listed in any of our use-case, and having the two separate sub-endpoints
(visit/nodes and visit/paths) is enough.

Note: the server code was not fully updated after recent code clean up, so the
visit/ global endpoint needed: a new function on its own (repeating again the
code in visitNodes and visitPaths) and a custom class for the JSON output
format.

Diff Detail

Repository
rDGRPH Graph service
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

haltode created this revision.Mon, Jul 29, 4:10 PM
zack accepted this revision.Mon, Jul 29, 4:55 PM
This revision is now accepted and ready to land.Mon, Jul 29, 4:55 PM
This revision was automatically updated to reflect the committed changes.