from aiohttp import Response raises an ImportError.
Details
Details
- Reviewers
douardda ardumont - Group Reviewers
Reviewers - Commits
- rDCORE02faef83a21e: Remove fallback when aiohttp_utils is not installed.
Diff Detail
Diff Detail
- Repository
- rDCORE Foundations and core functionalities
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/268/ for more details.
Comment Actions
A smaller change would be importing Response from aiohttp.web instead of just aiohttp.
In that case it'd be nice to add a test for this code path.
Comment Actions
FTR, and IIRC, I did write this fallback stuff because aiohttp_utils was not available on stretch.
Since we do have a deb now, I'm ok with this simplification.
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/280/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/280/console