Page MenuHomeSoftware Heritage

Remove fallback when aiohttp_utils is not installed.
ClosedPublic

Authored by vlorentz on Jul 19 2019, 3:28 PM.

Details

Summary

from aiohttp import Response raises an ImportError.

Diff Detail

Repository
rDCORE Foundations and core functionalities
Branch
aiohttp_utils-fallback
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7587
Build 10859: tox-on-jenkinsJenkins
Build 10858: arc lint + arc unit

Event Timeline

I'm not sure about this back and forth... This was added not so long ago... See D1688

Might be discuss this with @douardda when he gets back

A smaller change would be importing Response from aiohttp.web instead of just aiohttp.

In that case it'd be nice to add a test for this code path.

FTR, and IIRC, I did write this fallback stuff because aiohttp_utils was not available on stretch.

Since we do have a deb now, I'm ok with this simplification.

This revision is now accepted and ready to land.Aug 29 2019, 1:30 PM
This revision was landed with ongoing or failed builds.Sep 2 2019, 4:11 PM
This revision was automatically updated to reflect the committed changes.